Conversation
|
Although stuttering occurs when scrolling through the world select list, it also does when dragging, so this isn't a problem with this PR. |
|
|
||
| void ScrolledSelectionList::handleScroll(bool down) | ||
| { | ||
| float diff = 5.0f * (down ? -1.0f : 1.0f); |
There was a problem hiding this comment.
Feels weird. Like, when you scroll up, and then down, it seems to "continue" scrolling in the direction I was first scrolling in. Maybe it should just instantly set the velocity.
Also I think you should add a timeout of a few ms where the world select is just loose (as if you were holding a finger on the scroll area)
There was a problem hiding this comment.
This comment is for RolledSelectionList? Problem doesn't appear with ScrolledSelectionList.
There was a problem hiding this comment.
Yes, oops... Comment is related to RolledSelectionList.
| { | ||
| float diff = 5.0f * (down ? -1.0f : 1.0f); | ||
| field_34 = field_30 = field_30 + diff; | ||
| field_28 = 0; |
There was a problem hiding this comment.
you should probably rename the unnamed fields that you use, only a suggestion though
There was a problem hiding this comment.
Agree with this but I think these classes should be rewritten instead.
There was a problem hiding this comment.
Agree with this but I think these classes should be rewritten instead.
Disagree. These classes implement the base of scrollable list views. I don't see how they need to be rewritten.
4 participants
Fixes #107