Skip to content

Conversation

@MichaelCrawfordNava
Copy link
Contributor

@MichaelCrawfordNava MichaelCrawfordNava commented Oct 20, 2025

Ticket

Resolves TSS-388

Changes

  • Updated certification cases controller to only fetch actionable cases
    • This means that a case will not show on the "Open" cases page if it does not have any associated tasks

Context for reviewers

Testing

  • Reset your local database
  • Run the app locally
  • Navigate to cases
  • Go into a case
  • From the case page, go into a task
  • Complete the task
  • Go back to the cases page and ensure that the case no longer appears

Preview environment for reporting-app

♻️ Environment destroyed ♻️

@MichaelCrawfordNava MichaelCrawfordNava marked this pull request as ready for review October 20, 2025 21:08
@MichaelCrawfordNava MichaelCrawfordNava requested review from a team as code owners October 20, 2025 21:08
@nkutub nkutub merged commit fd2693b into main Oct 20, 2025
6 checks passed
@nkutub nkutub deleted the cael/only-show-actionable-cases branch October 20, 2025 21:42
@github-actions github-actions bot restored the cael/only-show-actionable-cases branch October 20, 2025 21:44
@lorenyu
Copy link
Contributor

lorenyu commented Oct 21, 2025

@nkutub small team norms comment for future reference, when merging to main, we set the repo settings to include the PR description by default, but there are often things in the PR description that aren't needed in the final commit to main. For example, in this squash merge commit fd2693b

I would have removed the "Ticket, Context for reviewers, Testing, and PR environment sections" and just left it as

Only retrieve actionable cases

- Updated certification cases controller to only fetch actionable cases
- This means that a case will not show on the "Open" cases page if it
does not have any associated tasks
---------
Co-authored-by: Nader Kutub <[email protected]>

(note the PR title itself I would have also changed to follow git commit naming conventions using imperative voice, etc)

@MichaelCrawfordNava MichaelCrawfordNava deleted the cael/only-show-actionable-cases branch October 21, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants