Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated source and destination labels for Infoblox "Prefix -> VLAN" relationship #722

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Updated source and destination labels for Infoblox "Prefix -> VLAN" relationship #722

wants to merge 4 commits into from

Conversation

michalbil
Copy link

Closes: #721

What's Changed

Updated source_label and destination_label for Infoblox "Prefix -> VLAN" relationship in order to:

  • avoid conflict with ipam:prefix model (as described in the issue to resolve)
  • make labels more meaningful

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@michalbil michalbil requested review from qduk, jdrew82 and a team as code owners March 7, 2025 17:48
@michalbil michalbil changed the title fix: Updated source and destination labels for Infoblox "Prefix -> VLAN" relationship Updated source and destination labels for Infoblox "Prefix -> VLAN" relationship Mar 7, 2025
progala
progala requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalbil . I've suggested more descriptive label names to make it obvious this is related to the Infoblox SSoT integration.

https://docs.infoblox.com/space/nios90/280400578/Assigning+VLANs+to+a+Network

michalbil and others added 2 commits March 10, 2025 11:45
@michalbil @progala
Update source_label
82e0bf6 
Co-authored-by: Przemek Rogala <[email protected]>
@michalbil @progala
Update destination_label
132e6e6 
Co-authored-by: Przemek Rogala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progala progala progala approved these changes

@qduk qduk Awaiting requested review from qduk qduk is a code owner

@jdrew82 jdrew82 Awaiting requested review from jdrew82 jdrew82 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infoblox SSoT plugin "Prefix -> VLAN" relationship source label conflicts with ipam:prefix model
2 participants
@michalbil @progala