-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conditional views in Golden Config #847
base: develop
Are you sure you want to change the base?
Conversation
47e4b89
to
3113bf9
Compare
|
AS far as this concern: "UI-based configuration settings would apply to each device individually within a dynamic group, rather than checking the configuration globally once." I don't expect this to cause much performance issue as we already have function |
1691aa5
to
452947c
Compare
nautobot_golden_config/migrations/0031_goldenconfigsetting_backup_enabled_and_more.py
Outdated
Show resolved
Hide resolved
Doing a full review of this today. |
@jtdub here's my first review. Many seems like we need to harden the checks before things execute based on GC setting (setting) variable.
|
Closes #842.
Navigation views display all options regardless of what is enabled or disabled:
Golden Config Settings displays whether backups and intended are enabled:
Creating and Updating Golden Config Settings in the UI:
Reading the Golden Config Settings in the UI.