Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mysql tests and reenabled mysql tests in CI. #410

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

gsnider2195
Copy link
Contributor

No description provided.

validatedsoftwarelcm.device_types.set([device_type]) # pylint: disable=no-member
validatedsoftwarelcm.save()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly shocked that this (wrong) order of operations worked in Postgres...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too. Pretty odd behavior all around

Copy link
Contributor

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing this! I am surprised like Glenn that this works in Postgres. I will be checking other repos to see if this issue exists.

@gsnider2195 gsnider2195 merged commit da62cc9 into develop Jan 22, 2025
15 checks passed
@gsnider2195 gsnider2195 deleted the u/gas-reenable-mysql-ci-tests branch January 22, 2025 20:26
@smk4664 smk4664 mentioned this pull request Jan 29, 2025
@glennmatthews
Copy link

Did this close #372?

@gsnider2195
Copy link
Contributor Author

Did this close #372?

Yes, you beat us to it by 20 minutes! It's closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants