-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filtering options, add contracts to device detail page, add device hardware notice reporting #357
Conversation
The min Nautobot version for this update is 2.2.3 which is consistent with what is in tasks.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Dav-C , this is going to be a great addition!
I left some comments and suggestions. Please review them and let me know if you have any questions.
...ce_lifecycle_mgmt/templates/nautobot_device_lifecycle_mgmt/hardwarenotice_device_report.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Przemek Rogala <[email protected]>
Co-authored-by: Przemek Rogala <[email protected]>
Co-authored-by: Przemek Rogala <[email protected]>
Co-authored-by: Przemek Rogala <[email protected]>
Co-authored-by: Przemek Rogala <[email protected]>
Co-authored-by: Przemek Rogala <[email protected]>
Update doc strings, rename some variables, general housekeeping Co-authored-by: Przemek Rogala <[email protected]>
revert filter field names to "expired" Co-authored-by: Przemek Rogala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome work @Dav-C !
Update filters and filter forms to include more fields and latest syntax for:
Add device hardware notice reporting including:
Add Contracts to the device detail pages.
Update tests
Update docs