Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filtering options, add contracts to device detail page, add device hardware notice reporting #357

Merged
merged 55 commits into from
Aug 14, 2024

Conversation

Dav-C
Copy link

@Dav-C Dav-C commented Jul 15, 2024

Update filters and filter forms to include more fields and latest syntax for:

  • Hardware Notices
  • Contracts

Add device hardware notice reporting including:

  • Model for holding report data
  • Reporting Job
  • Report View
  • List View
  • Serializer
  • Filter Forms/Filters
  • New graph generation method

Add Contracts to the device detail pages.

  • Include the 5 contracts with the latest end date

Update tests
Update docs

@Dav-C Dav-C requested review from jvanderaa and progala as code owners July 15, 2024 19:13
@Dav-C
Copy link
Author

Dav-C commented Jul 15, 2024

The min Nautobot version for this update is 2.2.3 which is consistent with what is in tasks.py

@progala progala self-assigned this Jul 26, 2024
Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dav-C , this is going to be a great addition!

I left some comments and suggestions. Please review them and let me know if you have any questions.

Dav-C and others added 2 commits July 31, 2024 08:11
Dav-C and others added 21 commits July 31, 2024 08:14
Update doc strings, rename some variables, general housekeeping

Co-authored-by: Przemek Rogala <[email protected]>
revert filter field names to "expired"

Co-authored-by: Przemek Rogala <[email protected]>
Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome work @Dav-C !

@progala progala merged commit 42c0d19 into next3.0 Aug 14, 2024
15 checks passed
@Dav-C Dav-C deleted the dcates-update-contracts-reporting branch October 29, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants