Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #343 #351

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Fix #343 #351

merged 9 commits into from
Aug 14, 2024

Conversation

pszulczewski
Copy link
Contributor

Update to hardware notice form to use DynamicModelChoiceField to prevent populating all inventory items and hanging the browser.

@pszulczewski
Fix #343 - updated hardware notice form to use DynamicModelChoiceFiel…
b37f118 
…d to prevent populating all inventory items.
@pszulczewski pszulczewski linked an issue Jul 9, 2024 that may be closed by this pull request
Update the UX for add/edit a Hardware Notice #343
Closed
@pszulczewski pszulczewski force-pushed the 343-update-the-ux-for-addedit-a-hardware-notice branch from b40d00b to 1e3334d Compare July 10, 2024 09:09
progala
progala requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is going to work for Inventory Items that don't have a value for Part ID. We should make sure these are excluded.

Do we also need to fix HardwareLCMFilterForm?

@pszulczewski pszulczewski requested a review from progala July 12, 2024 13:28
@bradh11
Copy link
Contributor

bradh11 commented Jul 12, 2024

@progala let's make sure we backport this to ltm 1.6

progala
progala approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@progala progala merged commit 99fbdb9 into develop Aug 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progala progala progala approved these changes

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the UX for add/edit a Hardware Notice
3 participants
@pszulczewski @bradh11 @progala