Skip to content

Conversation

ms32035
Copy link
Contributor

@ms32035 ms32035 commented Sep 5, 2025

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • [ X] I have reviewed the CONTRIBUTING.md and followed the established practices

Summary

An additional parameter to support data deduplication that could have occurred due to using skip_disjoint_check

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Documentation

  • Documentation changes follow the style guide (docs/developer_guide/docs.md)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@cjdsellers
Copy link
Member

Hi @ms32035

When you get a chance could you please rebase on latest develop. There's a more robust CI installation routine which will overcome the current fails.

@ms32035 ms32035 force-pushed the feature/consolidate_deduplication branch from 612ab31 to 7000ef9 Compare September 7, 2025 09:43
@cjdsellers
Copy link
Member

Thanks for the contribution @ms32035 🙏

@cjdsellers cjdsellers merged commit 58e8781 into nautechsystems:develop Sep 7, 2025
13 checks passed
@ms32035 ms32035 deleted the feature/consolidate_deduplication branch September 7, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants