Add missing stubs for brew snippets and master pages (Master Pages Pt 1) #3792
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates ) Updated tests to match.
dbolack-ab
changed the title
dbolack-ab
changed the title
|
Just FYI on this series of PRs, I am going to put this on lower priority until we decide if Master pages are a feature we actually want to pursue yet. Just given the size of this feature, I don't want to get myself too involved in reviews until the discussion in #3783 comes to a conclusion on both need and approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some missing bits for snippets stubs and adds the same for master pages.
I chose to name the field
templatesas it may be a better term for the user base than master pages when it comes to intent of the feature.Updates tests to account for the helper function returning the template stub.
In addition to providing stubs, this provides direct support for #2804 and #3022.