Repository navigation
Conversation
… the CA The wrapper sets SSL_CERT_FILE/REQUESTS_CA_BUNDLE/... on the entrypoint process only. Processes started via exec are seeded from the container spec instead and never see them, so CA injection silently did nothing for every step of a GitHub Actions container job (ARC's k8s container hooks run each step as a pod exec). Python is hit hardest: requests/zeep read certifi, not the OS trust store, so the merged store the hook writes doesn't help either. Bind-mount the per-container CA dir read-only at /etc/cainjekt-ca and put the trust env vars on the NRI adjustment, pointing at fixed paths under it. The plugin seeds the merged bundle with its own image's roots so the trust-replacing vars resolve to a complete bundle from container start; the hook then refines it with the container's actual store. Entrypoint processes are unaffected — the wrapper still overrides with the in-place store. Also fixes the read-only-rootfs path, which set FactIndividualCAPath and FactMergedCAPath to host paths under /run/cainjekt/containers/. Nothing mounted that directory into the container, so those env vars pointed at files the container could not see. They now name the paths as the container sees them. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
On hold: the bind-mounted CA dir is labelled |
janlauber
force-pushed
the
fix/exec-visible-trust-env
branch
from
October 28, 2026 14:36
ce47c8e to
40f6a6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrapper sets
SSL_CERT_FILE,REQUESTS_CA_BUNDLEand the other trust env vars on the entrypoint process only. Processes started with exec get their env from the container spec, so they never see the CA. This breaks every step of a GitHub Actions container job on ARC, because each step runs as a pod exec.The plugin now bind-mounts the per-container CA dir read-only at
/etc/cainjekt-caand sets the trust env vars on the NRI adjustment. The plugin seeds the bundle with its own image's roots, and the hook then refines it with the container's own store. Entrypoint processes are unaffected.This also fixes the read-only rootfs path. It set the CA path facts to host paths under
/run/cainjekt/containers/, which nothing mounts into the container. They now name the paths the container sees. The .NET processor relies on that path.Rebased onto main.
go test ./...andgolangci-lintpass. Not yet tested on a cluster. This PR conflicts with thefeat/rootfs-boundaryPR inosstore.go.