Skip to content

fix: add warning for [email protected] #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marklawlor merged 2 commits into from
Oct 11, 2025
Merged

fix: add warning for [email protected] #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
505f431
fix: add warning for [email protected]
marklawlor Oct 10, 2025
770608d
Update src/compiler/lightningcss-loader.ts
marklawlor Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/compiler/lightningcss-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable @typescript-eslint/no-require-imports */
export function lightningcssLoader() {
let lightningcssPath: string | undefined;

Expand Down Expand Up @@ -28,11 +29,29 @@ export function lightningcssLoader() {
);
}

// eslint-disable-next-line @typescript-eslint/no-require-imports
const { transform: lightningcss, Features } = require(
lightningcssPath,
) as typeof import("lightningcss");

try {
const lightningcssPackageJSONPath = require.resolve("../../package.json", {
Copy link

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The require.resolve path '../../package.json' is incorrect for resolving the lightningcss package.json. It should be 'lightningcss/package.json' to resolve the actual lightningcss package's package.json file.

Suggested change
const lightningcssPackageJSONPath = require.resolve("../../package.json", {
const lightningcssPackageJSONPath = require.resolve("lightningcss/package.json", {

Copilot uses AI. Check for mistakes.
paths: [lightningcssPath],
});

const packageJSON = require(lightningcssPackageJSONPath) as Record<
string,
unknown
>;

if (packageJSON.version === "1.30.2") {
throw new Error(
"[react-native-css] lightningcss version 1.30.2 has a critical bug that breaks compilation. Please pin the version of lightningcss to 1.30.1; or try upgrading.",
);
}
} catch {
// Intentionally left empty
}

return {
lightningcss,
Features,
Expand Down