Skip to content

Conversation

@marklawlor
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings September 8, 2025 08:54
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the public exports and module structure by reorganizing internal imports and updating package.json exports. The changes consolidate utilities, simplify import paths, and add new public exports for better API accessibility.

  • Consolidates utility functions into a shared utilities module with public exports
  • Updates internal imports to use the new public module structure instead of deep relative paths
  • Adds new public exports (./native, ./web, ./utilities) to package.json for better API access

Reviewed Changes

Copilot reviewed 42 out of 72 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Adds new public exports and reorganizes existing export order
src/utilities/index.ts Creates new utilities export barrel
src/runtime.types.ts Consolidates React component types and updates imports
Multiple source files Updates imports to use public module paths instead of relative paths
Test files Updates imports to use new public module structure
Example files Updates configuration and dependencies to use new module structure
Comments suppressed due to low confidence (1)

src/native/conditions/attributes.ts:1

  • Same type safety concern as above - the change from Props to a generic record type reduces type safety and may lead to runtime errors that were previously caught at compile time.
import type { AttributeQuery } from "react-native-css/compiler";

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 6 to 8
queries: AttributeQuery[],
props: Props,
props: Record<string, unknown> | undefined | null,
guards: RenderGuard[],
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter type change from Props to Record<string, unknown> | undefined | null removes type safety. Consider keeping the original Props type or creating a more specific interface that maintains type information while allowing the flexibility needed.

Copilot uses AI. Check for mistakes.
@marklawlor marklawlor force-pushed the 09-08-fix_improve_public_exports branch from 94f7cc6 to 9b2062a Compare September 9, 2025 04:21
@graphite-app
Copy link

graphite-app bot commented Sep 9, 2025

Merge activity

  • Sep 9, 6:51 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Sep 9, 6:51 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@marklawlor marklawlor force-pushed the 09-08-fix_improve_public_exports branch from 9b2062a to cff0638 Compare September 9, 2025 12:26
@marklawlor marklawlor enabled auto-merge (squash) September 9, 2025 12:28
@marklawlor marklawlor force-pushed the 09-08-fix_improve_public_exports branch from cff0638 to 71876a3 Compare September 9, 2025 12:36
@marklawlor marklawlor merged commit aeb0085 into main Sep 9, 2025
7 checks passed
@marklawlor marklawlor deleted the 09-08-fix_improve_public_exports branch September 9, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants