-
Notifications
You must be signed in to change notification settings - Fork 22
fix: improve public exports #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request improves the public exports and module structure by reorganizing internal imports and updating package.json exports. The changes consolidate utilities, simplify import paths, and add new public exports for better API accessibility.
- Consolidates utility functions into a shared
utilitiesmodule with public exports - Updates internal imports to use the new public module structure instead of deep relative paths
- Adds new public exports (
./native,./web,./utilities) to package.json for better API access
Reviewed Changes
Copilot reviewed 42 out of 72 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds new public exports and reorganizes existing export order |
| src/utilities/index.ts | Creates new utilities export barrel |
| src/runtime.types.ts | Consolidates React component types and updates imports |
| Multiple source files | Updates imports to use public module paths instead of relative paths |
| Test files | Updates imports to use new public module structure |
| Example files | Updates configuration and dependencies to use new module structure |
Comments suppressed due to low confidence (1)
src/native/conditions/attributes.ts:1
- Same type safety concern as above - the change from
Propsto a generic record type reduces type safety and may lead to runtime errors that were previously caught at compile time.
import type { AttributeQuery } from "react-native-css/compiler";
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| queries: AttributeQuery[], | ||
| props: Props, | ||
| props: Record<string, unknown> | undefined | null, | ||
| guards: RenderGuard[], |
Copilot
AI
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter type change from Props to Record<string, unknown> | undefined | null removes type safety. Consider keeping the original Props type or creating a more specific interface that maintains type information while allowing the flexibility needed.
94f7cc6 to
9b2062a
Compare
Merge activity
|
9b2062a to
cff0638
Compare
cff0638 to
71876a3
Compare

No description provided.