Skip to content

Conversation

@marklawlor
Copy link
Contributor

@marklawlor marklawlor commented Sep 8, 2025

Fix #169

Copilot AI review requested due to automatic review settings September 8, 2025 04:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates the API exports by moving the VariableContext from the reactivity module to the style-collection module and updating all imports to use the consistent export path. The key changes ensure that all React Context instances are created once globally and exported from a single location.

  • Moved VariableContext creation from reactivity module to style-collection module with global singleton pattern
  • Updated VAR_SYMBOL to use Symbol.for() for global symbol registry
  • Updated all import statements across the codebase to use the new export location

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/style-collection/index.ts Added VariableContext creation and export with global singleton pattern
src/runtime/native/reactivity.ts Removed VariableContext creation, changed VAR_SYMBOL to use Symbol.for()
src/runtime/native/react/useNativeCss.ts Updated VariableContext import to use style-collection export
src/runtime/native/api.tsx Updated exports and imports to use style-collection for VariableContext
src/components/react-native-safe-area-context.native.tsx Updated VariableContext import path
src/tests/native/variables.test.tsx Updated import path for VariableContextProvider
src/tests/native/units.test.tsx Updated VariableContext import path
example/src/App.tsx Enhanced example with VariableContextProvider usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@marklawlor marklawlor enabled auto-merge (squash) September 8, 2025 04:08
@marklawlor marklawlor merged commit 920bf2d into main Sep 8, 2025
7 checks passed
@marklawlor marklawlor deleted the 09-08-fix_consistent_api_exports branch September 8, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VariableContext is lost when importing components from react-native-css

2 participants