Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark mode #293

Merged
merged 15 commits into from
Aug 20, 2024
Merged

Add Dark mode #293

merged 15 commits into from
Aug 20, 2024

Conversation

amochuko
Copy link
Contributor

@amochuko amochuko commented Aug 14, 2024

The PR enable a Dark theme of the web app

Related GitHub Issue

Update related to #292

Screenshots (if appropriate):

How Has This Been Tested?

  • Status checks pass (lint, build, test)
  • Works on Sepolia preview deployment
  • Works on Mainnet preview deployment

Are There Admin Tasks?

No

@amochuko amochuko requested a review from a team as a code owner August 14, 2024 14:12
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
citizen-app-mainnet ✅ Ready (Inspect) Visit Preview Aug 20, 2024 5:21am
citizen-app-sepolia ✅ Ready (Inspect) Visit Preview Aug 20, 2024 5:21am

Copy link

vercel bot commented Aug 14, 2024

@amochuko is attempting to deploy a commit to the Nation3 DAO Team on Vercel.

A member of the Team first needs to authorize it.

@amochuko
Copy link
Contributor Author

WIP with remaining two items:

  1. The logo
  2. Hamburger icon (Nav bar)

Kindly take a look over and let me your thoughts.
Thanks

@amochuko
Copy link
Contributor Author

WIP with remaining two items:

  1. The logo
  2. Hamburger icon (Nav bar)

Kindly take a look over and let me your thoughts. Thanks

I got item 2 done; and created a placeholder for item 1 which I intend to fill with a logo that would fit a dark mode.

Copy link
Member

@aahna-ashina aahna-ashina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amochuko When I hover a menu item in light mode, the item's background color changes. Can we keep this functionality in dark mode?

@amochuko
Copy link
Contributor Author

@amochuko When I hover a menu item in light mode, the item's background color changes. Can we keep this functionality in dark mode?

Sure, we can. I'll go rectify it.

@amochuko
Copy link
Contributor Author

@amochuko When I hover a menu item in light mode, the item's background color changes. Can we keep this functionality in dark mode?

I've made a fix.

@aahna-ashina
Copy link
Member

Thank you, @amochuko. Can you also change the alert div at https://citizen-app-mainnet-git-fork-amochuko-dark-mode-nation3dao.vercel.app/lock into dark theme?

@amochuko
Copy link
Contributor Author

Thank you, @amochuko. Can you also change the alert div at https://citizen-app-mainnet-git-fork-amochuko-dark-mode-nation3dao.vercel.app/lock into dark theme?

I've updated the alert on Dark mode and ensured keeping it still noticeable.

@aahna-ashina
Copy link
Member

I've updated the alert on Dark mode and ensured keeping it still noticeable.

@amochuko I don't see any dark theme added with your latest commit. Am I looking at the correct preview URL? - https://citizen-app-mainnet-git-fork-amochuko-dark-mode-nation3dao.vercel.app/

@amochuko
Copy link
Contributor Author

I've updated the alert on Dark mode and ensured keeping it still noticeable.

@amochuko I don't see any dark theme added with your latest commit. Am I looking at the correct preview URL? - https://citizen-app-mainnet-git-fork-amochuko-dark-mode-nation3dao.vercel.app/

I wanted the alert message to still remain noticeable in a Dark mode so I used dark:bg-slate-200 (mild shade); but I've replaced with dark:bg-slate-300

@aahna-ashina aahna-ashina merged commit c914786 into nation3:main Aug 20, 2024
6 checks passed
@amochuko amochuko deleted the dark-mode branch August 20, 2024 05:54
@aahna-ashina aahna-ashina mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants