Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove all files related to Goerli #291

Merged
merged 3 commits into from
Aug 14, 2024
Merged

fix: remove all files related to Goerli #291

merged 3 commits into from
Aug 14, 2024

Conversation

amochuko
Copy link
Contributor

@amochuko amochuko commented Aug 14, 2024 •
edited
Loading

This contain changes that include the deleting all files related to Goerli

Related GitHub Issue

#290

Screenshots (if appropriate):

How Has This Been Tested?

  • Status checks pass (lint, build, test)
  • Works on Sepolia preview deployment
  • Works on Mainnet preview deployment

Are There Admin Tasks?

No

@amochuko amochuko requested a review from a team as a code owner August 14, 2024 05:20
@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024

@amochuko is attempting to deploy a commit to the Nation3 DAO Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
citizen-app-mainnet ✅ Ready (Inspect) Visit Preview Aug 14, 2024 7:15am
citizen-app-sepolia ✅ Ready (Inspect) Visit Preview Aug 14, 2024 7:15am

aahna-ashina
aahna-ashina requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@aahna-ashina aahna-ashina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amochuko Looks there was some leftover work not completed as part of #261. And in those cases, we should replace "goerli" with "sepolia" instead of deleting it.

ui/components/SwitchNetworkBanner.tsx Show resolved Hide resolved
ui/lib/config.ts Show resolved Hide resolved
ui/lib/connectors.ts Show resolved Hide resolved
ui/lib/connectors.ts Show resolved Hide resolved
@amochuko
Copy link
Contributor Author

@amochuko Looks there was some leftover work not completed as part of #261. And in those cases, we should replace "goerli" with "sepolia" instead of deleting it.

oooh, my bad... I'll go fix it now.

@amochuko
Copy link
Contributor Author

@amochuko Looks there was some leftover work not completed as part of #261. And in those cases, we should replace "goerli" with "sepolia" instead of deleting it.

I have made the fix for it

@aahna-ashina aahna-ashina merged commit 6b3520c into nation3:main Aug 14, 2024
6 checks passed
@aahna-ashina aahna-ashina mentioned this pull request Aug 14, 2024
Closed
@amochuko amochuko deleted the remove-goerli branch August 14, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aahna-ashina aahna-ashina aahna-ashina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amochuko @aahna-ashina