Skip to content

fix(twitter): restore readers and harden reply flow - #65

Open
kannch8765 wants to merge 5 commits into
nashsu:mainfrom
kannch8765:fix/twitter-upstream-sync
Open

fix(twitter): restore readers and harden reply flow#65
kannch8765 wants to merge 5 commits into
nashsu:mainfrom
kannch8765:fix/twitter-upstream-sync

Conversation

@kannch8765

Copy link
Copy Markdown

Fixes #64

Summary

  • fix collect to read the same window.__autocli_intercepted buffer populated by AutoCLI's browser interceptor
  • accept current X timeline_v2 user timelines in followers and following
  • use AutoCLI's supported count / delay scroll fields in notifications
  • harden twitter reply using the current OpenCLI flow: dedicated reply composer, text verification, both submit-button variants, and fresh success evidence before reporting success

The three empty reader commands shared a single runtime bug: the interceptor writes to window.__autocli_intercepted, while CollectStep was still reading the old OpenCLI name window.__opencli_intercepted. Only these three Twitter adapters currently use collect, which matches the affected surface in #64.

OpenCLI references

This ports behavior from the current upstream reference implementation and its later X compatibility fixes, including:

  • jackwener/OpenCLI@f4637486 — followers rewrite after the old intercept flow broke
  • jackwener/OpenCLI@7c5bafd / jackwener/OpenCLI@90e4cb9 — following fixes and current timeline/query handling
  • jackwener/OpenCLI@f321a609 / jackwener/OpenCLI@da3eb951 / jackwener/OpenCLI@ca25f148 — reply submission hardening and success verification
  • jackwener/OpenCLI@56360604 — current followers timeline_v2 parsing

Validation

  • cargo test -p autocli-pipeline --lib -- --skip steps::download::tests::test_download_with_url_in_data — 73 passed
  • cargo test -p autocli-discovery --lib — 3 passed
  • cargo check -p autocli — passed
  • all four modified adapter YAML files parse successfully
  • all embedded JavaScript snippets pass node --check
  • synthetic timeline_v2 fixtures return expected rows for both followers and following
  • the skipped download test also fails unchanged on clean c0969e2, so it is an existing baseline failure unrelated to this patch

Align the collect step with AutoCLI’s interceptor buffer, accept current X timeline_v2 user timelines, and use the supported scroll option names for notifications.
Port the current OpenCLI reply flow concepts: use X’s dedicated reply composer, verify inserted text, support both submit button variants, and require fresh success evidence before reporting success.
@kannch8765

Copy link
Copy Markdown
Author

Live Windows/X smoke test on the PR branch:

  • twitter notifications — PASS; returned a fresh mention plus existing likes/follows/mentions instead of [].
  • twitter following — PASS; returned all 6 visible following accounts instead of [].
  • twitter followers — PASS after 4208b67; returned all 6 visible follower accounts instead of [].
  • twitter reply — not live-tested yet because it performs a public write.

Tested with the same authenticated Chrome/X session described in #64 using a Windows x86-64 release build of this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Twitter reply fails; followers/following/notifications return empty

1 participant