Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time Strip] allow user to adjust width and height of swimlanes #8003

Draft
wants to merge 10 commits into
base: 7936-add-discrete-event-visualization
Choose a base branch
from

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Feb 27, 2025

Closes #7957

Describe your changes:

  • custom width adjustment, will adjust all swimlane widths
    • custom width adjustment inside a nested time strip
  • custom height adjustment, based on percentage of viewing space
    • stacked plots scaled per composition
  • persist width adjustment
  • persist height adjustment
  • fix handles for nested plans not resizing
  • fix handles for plan labels nested in time strips resizing all
  • have flexible layouts use new composable for flex container reactivity
    • verify existing e2e tests
  • make resizeHandle reusable
  • e2e tests for time strips

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

davetsay and others added 10 commits January 10, 2025 13:12
- timeline-holder now set to 100% height.
- c-swimlane now space-fills available vertical space, and provides overflow scroll.
- resize is not yet persisted
- WIP!
- Moved many CSS defs from flexible-layout.scss into new mixin `resizeHandleStyle`.
- Fixed bad `drap-orientation` arg in TimelineViewLayout.vue.
- Styling for resize handles in Time Strip view.
@davetsay davetsay requested a review from charlesh88 February 27, 2025 18:29
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 50.53763% with 46 lines in your changes missing coverage. Please review.

Project coverage is 56.89%. Comparing base (32a0e15) to head (af912db).

Files with missing lines Patch % Lines
src/utils/vue/useDragResizer.js 16.00% 21 Missing ⚠️
src/utils/vue/useFlexContainers.js 55.00% 18 Missing ⚠️
src/plugins/timeline/TimelineViewLayout.vue 58.33% 5 Missing ⚠️
src/plugins/timeline/Container.js 83.33% 1 Missing ⚠️
src/plugins/timeline/TimelineObjectView.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##           7936-add-discrete-event-visualization    #8003      +/-   ##
=========================================================================
- Coverage                                  57.18%   56.89%   -0.30%     
=========================================================================
  Files                                        686      689       +3     
  Lines                                      27825    27916      +91     
  Branches                                    2741     2742       +1     
=========================================================================
- Hits                                       15913    15883      -30     
- Misses                                     11569    11691     +122     
+ Partials                                     343      342       -1     
Flag Coverage Δ
e2e-ci 62.89% <47.36%> (+0.01%) ⬆️
e2e-full 23.47% <0.00%> (-18.26%) ⬇️
unit 48.67% <24.73%> (-0.09%) ⬇️
Files with missing lines Coverage Δ
...s/flexibleLayout/components/ContainerComponent.vue 10.63% <ø> (ø)
...ugins/flexibleLayout/components/FlexibleLayout.vue 8.05% <ø> (ø)
src/plugins/flexibleLayout/plugin.js 100.00% <ø> (ø)
src/plugins/plan/components/PlanView.vue 59.49% <ø> (ø)
src/plugins/timeline/TimelineViewProvider.js 100.00% <100.00%> (ø)
src/ui/components/swim-lane/SwimLane.vue 64.51% <100.00%> (+5.25%) ⬆️
src/ui/layout/Container.js 100.00% <ø> (ø)
src/ui/layout/Frame.js 100.00% <ø> (ø)
src/ui/layout/ResizeHandle/ResizeHandle.vue 15.38% <ø> (ø)
src/plugins/timeline/Container.js 83.33% <83.33%> (ø)
... and 4 more

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a0e15...af912db. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants