Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] FpySequencer 0.1 #3334

Open
wants to merge 34 commits into
base: devel
Choose a base branch
from

Conversation

zimri-leisher
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

The 0.1 version of the FpySequencer, which replicates the functionality of the existing CmdSequencer component.

Rationale

Part of the roadmap for the implementation of the advanced sequencing language.

Testing/Review Recommendations

TBD

Future Work

TBD

Zimri Leisher and others added 30 commits November 25, 2024 16:39
this->sequencer_sendSignal_statementResponseIn(
FpySequencer_StatementResponse(m_runtime.currentStatementOpcode, Fw::CmdResponse::OK));
}
} // namespace Svc

Check warning

Code scanning / CppCheck

Could not find a newline character at the end of the file. Warning

Could not find a newline character at the end of the file.
return m_goalState == FpySequencer_GoalState::RUNNING;
}

} // namespace Svc

Check warning

Code scanning / CppCheck

Could not find a newline character at the end of the file. Warning

Could not find a newline character at the end of the file.
return true;
}

} // namespace Svc

Check warning

Code scanning / CppCheck

Could not find a newline character at the end of the file. Warning

Could not find a newline character at the end of the file.
return this->m_bufferData;
}

bool StatementArgBuffer::operator==(const StatementArgBuffer& other) const {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to make another one of these Bufs cuz none of the other ones were usable in an fpp struct

<channel name="Ref.cmdSeq.CS_CancelCommands"/>
<channel name="Ref.cmdSeq.CS_CommandsExecuted"/>
<channel name="Ref.cmdSeq.CS_SequencesCompleted"/>
<channel name="Ref.fpySeq.SequencesCompleted"/>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to ref topo for now, down to discuss

@@ -102,6 +102,10 @@ module Ref {
stack size Default.STACK_SIZE \
priority 96

instance fpySeq: Svc.FpySequencer base id 0x1200 \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo delete old seq

result = dispatchCommand(nextStatement);
}

m_runtime.statementIndex++;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to indicate this is the next statement idx


Fw::Time currentTime = getTime();

if (currentTime.getTimeBase() != m_runtime.wakeupTime.getTimeBase()) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment explaining what has happened... tb changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant