New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve warning flags in builds #3319

Open

bocchino wants to merge 61 commits into nasa:devel from bocchino:fix-warnings

Collaborator

bocchino commented Mar 3, 2025 •

edited

Loading

Update FPP version
Add default warning flags and make them consistent across the various builds (fprime, Ref, RPI, --ut)
Where a new warning breaks the compilation of a build module
- Where feasible, improve the code to eliminate the warning
- Otherwise turn off that warning for that build module

Closes #3289.

Future Work

In places where warnings are turned off, improve the code and then turn the warnings on

bocchino added 17 commits

February 19, 2025 09:53


          Update fpp version

01d0a54

Add more warnings to FppTest


          Update fpp version

cf9368e

Add warnings to build


          Enable warnings in unit tests

dc8af74

Fix warnings


          Clean up test code

1b95a50


          Update fpp version

cab2100

Remove workarounds in unit test builds


          Update fpp version

Fix warnings


          Revise DpManager tests

d9379f2

Remove conversion warnings


          Revise DpWriter tests

f35d0cd

Remove conversion warnings


          Refactor Hash

018dadc

Provide a size type to remove dependencies on NATIVE_INT_TYPE,
which is going away.


          Revise top-level CMakeLists.txt

64e5598


          Merge branch 'devel' into fix-warnings

ef9513e


          Fix warnings in Ref

0712dcc


          Fix warnings in Ref, RPI

6f6f9a8


          Revise warning flags

4e01c6d


          Revise code to eliminate warnings

1d5f694


          Revise code to fix warnings

aef7fdf


          Revise code to fix warnings

93fd71f

github-advanced-security bot found potential problems

View reviewed changes

Fw/Types/StringUtils.cpp Dismissed Show dismissed Hide dismissed

bocchino added 2 commits

March 3, 2025 09:14


          Revise code to fix warnings

2fb7cfa


          Revise Serializable.cpp

b018b85

github-advanced-security bot found potential problems

View reviewed changes

Fw/Types/Serializable.cpp Dismissed Show dismissed Hide dismissed


          Revise Serializable.cpp

f95e8e8

github-advanced-security bot found potential problems

View reviewed changes

Fw/Types/Serializable.cpp Dismissed Show dismissed Hide dismissed

Fw/Types/Serializable.cpp Dismissed Show resolved Hide resolved

Fw/Types/Serializable.cpp Fixed Show resolved Hide resolved

bocchino added 3 commits

March 3, 2025 09:35


          Revise warning flags

00e6178


          Fix warnings in test code

0d84821


          Fix warnings

db079f2

github-advanced-security bot found potential problems

View reviewed changes

Os/Generic/PriorityQueue.cpp Fixed Show resolved Hide resolved

Os/Generic/PriorityQueue.cpp Fixed Show resolved Hide resolved

Os/Generic/PriorityQueue.cpp Fixed Show resolved Hide resolved

Os/Generic/PriorityQueue.cpp Fixed Show fixed Hide fixed

bocchino added 2 commits

March 3, 2025 10:07


          Fix warnings

faa2c3e


          Fix warnings and static analysis errors

5146fa2

github-advanced-security bot found potential problems

View reviewed changes

Os/Generic/PriorityQueue.cpp Dismissed Show dismissed Hide dismissed

Os/Generic/PriorityQueue.cpp Dismissed Show dismissed Hide dismissed

Os/Posix/File.cpp Fixed Show fixed Hide fixed

Os/Posix/File.cpp Fixed Show fixed Hide fixed

Os/Posix/FileSystem.cpp Dismissed Show dismissed Hide dismissed

bocchino added 2 commits

March 3, 2025 18:30


          Remove commented-out code

55b5d2f


          Update STest

fe79000

Eliminate warnings

bocchino mentioned this pull request

Fix warnings that appear when compiling with gcc nasa/fpp#647

Merged

bocchino added 2 commits

March 4, 2025 15:52


          Merge branch 'devel' into fix-warnings

375a77c


          Fix warning

ce78a75

github-advanced-security bot found potential problems

View reviewed changes

Fw/Types/MallocAllocator.cpp Dismissed Show dismissed Hide dismissed

github-advanced-security bot found potential problems

View reviewed changes

Fw/Types/MallocAllocator.cpp Dismissed Show dismissed Hide dismissed

bocchino added 2 commits

March 4, 2025 16:01


          Fix warnings

4f17e7e


          Fix warning

edca0a1

github-advanced-security bot found potential problems

View reviewed changes

Fw/Types/StringBase.cpp Dismissed Show dismissed Hide dismissed

github-advanced-security bot found potential problems

View reviewed changes

Fw/Types/StringBase.cpp Dismissed Show dismissed Hide dismissed

bocchino added 2 commits

March 4, 2025 16:14


          Fix warning

2b61999


          Fix warning

github-advanced-security bot found potential problems

View reviewed changes

Svc/TlmPacketizer/TlmPacketizer.cpp Fixed Show fixed Hide fixed

Svc/TlmPacketizer/TlmPacketizer.cpp Fixed Show fixed Hide fixed

bocchino added 4 commits

March 4, 2025 16:31


          Revise comments

e03ed2d


          Revise static cast expression

9f75b78


          Cast return type to void

51201de


          Remove unneeded cast

e1a3937

bocchino requested a review from LeStarch

March 5, 2025 01:26

bocchino marked this pull request as ready for review

March 5, 2025 01:26

Collaborator Author

bocchino commented Mar 6, 2025

@LeStarch @thomas-bc I noticed that the googletest compilation trips -Wconversion on the F Prime development machine. Is there a way to disable -Wconversion for the googletest build?

bocchino requested a review from thomas-bc

March 6, 2025 17:47

github-advanced-security bot found potential problems

View reviewed changes

Svc/TlmPacketizer/TlmPacketizer.cpp Dismissed Show dismissed Hide dismissed

Robert L Bocchino and others added 3 commits

March 6, 2025 10:02


          Fix warnings that appear on the F Prime dev machine

e2efc6f


          Fix more warnings

5e7db7f


          Enable more warnings

088377f

github-advanced-security bot found potential problems

View reviewed changes

Svc/Deframer/test/ut/DeframerTester.hpp Dismissed Show dismissed Hide dismissed

bocchino added 3 commits

March 7, 2025 10:48


          Update fpp version

3736c83


          Remove commented-out compiler flags

09eb3cd


          Enable warning flag in CmdDispatcher

20310f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet