-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gibs python use cases #30
Conversation
We decided in the GITC standup meeting that Alex and Matt would be the best to review |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I made the following updates suggested by Joe:
@jtroberts I tried to fix the properties about a tiff file cell with rasterio, but when I download the request to
Also, this is what the new reprojected image looks like: |
That makes sense given that you specified HEIGHT=512&WIDTH=512. I would change WIDTH=1024 to keep the image in the correct proportion. In that case, the expected output size should be 1024 x 512.
How about we use EASE Grid instead since it is a more common equal-area global projection? So EPSG:3857 to EPSG:6933. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! My last suggestion is to render that reprojected image in the notebook for reference but not a big deal.
Added showing the reprojected image to the notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Relevant use cases we identified in our ticket that I implemented in this PR:
https://scitools.org.uk/cartopy/docs/v0.15/examples/wmts.html ipyleaflet
https://ipyleaflet.readthedocs.io/en/latest/layers/wms_layer.html (WAS ALREADY IMPLEMENTED) folium
https://python-visualization.github.io/folium/latest/user_guide/raster_layers/wms_tile_layer.html
Other notes:
I verified that mapping wmts raster data with cartopy gives the same result as creating the jpg with gdal_translate from the .xml file.
Unfortunately, the animated gif example cannot be rendered in the docs page like the existing ipyleaflet example
I know you can’t see the changes from Git in this PR, but I like ReviewNB for looking at changes to notebooks
@jtroberts I wasn't sure who else to add as a reviewer for this PR