-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the aesthetics of this project #1317 #1329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you devArghya-0155! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
Quality Gate failedFailed conditions B Reliability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
hi @devArghya-0155 I'm traveling right now and will be free in a day, I'll review this pr then.Thanks for your patience |
Please review my pr and let me know what changes need to be made. |
Yes, really sorry for the delay, actually it's having merge conflicts which can only be solved on a desktop, that's why the delay |
also, can you please check the code analysis review, it's smelling something |
hi @devArghya-0155 can you please check if it's responsive... it's breaking in every screen |
I am working on these issues now. |
closed due to inactivity |
Changes made are listed below:
Changed the background colour of body, sidebar, navbar and suggestions. It works correctly in both light mode and dark mode.
Improved post structure -
Made some minor changes to few other components.
Please let me know if there are any errors. I will fix them at the earliest.