Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the aesthetics of this project #1317 #1329

Closed
wants to merge 2 commits into from

Conversation

devArghya-0155
Copy link
Contributor

Changes made are listed below:

  1. Changed the background colour of body, sidebar, navbar and suggestions. It works correctly in both light mode and dark mode.

  2. Improved post structure -

    • Changed the position of post caption. It is now above the post.
    • Fixed the colour of post caption. It had a grey background in dark mode.
    • Changed the structure of post nav. Post stats (number of likes and comments) and the option to like, comment, share & bookmark occupy the same place.
    • Added interactive screentips to each button.
    • Changed the background of comment box to separate it from other post content. Works correctly in both dark and light mode.
  3. Made some minor changes to few other components.

image

image

Please let me know if there are any errors. I will fix them at the earliest.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you devArghya-0155! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link

sonarcloud bot commented Jan 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@narayan954
Copy link
Owner

hi @devArghya-0155 I'm traveling right now and will be free in a day, I'll review this pr then.Thanks for your patience

@devArghya-0155
Copy link
Contributor Author

hi @devArghya-0155 I'm traveling right now and will be free in a day, I'll review this pr then.Thanks for your patience

Please review my pr and let me know what changes need to be made.

@narayan954
Copy link
Owner

hi @devArghya-0155 I'm traveling right now and will be free in a day, I'll review this pr then.Thanks for your patience

Please review my pr and let me know what changes need to be made.

Yes, really sorry for the delay, actually it's having merge conflicts which can only be solved on a desktop, that's why the delay

@narayan954 narayan954 linked an issue Jan 6, 2024 that may be closed by this pull request
5 tasks
@narayan954
Copy link
Owner

Quality Gate Failed Quality Gate failed

Failed conditions

B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

also, can you please check the code analysis review, it's smelling something

@narayan954
Copy link
Owner

narayan954 commented Jan 6, 2024

hi @devArghya-0155 can you please check if it's responsive... it's breaking in every screen

references:
image
image
image

@devArghya-0155
Copy link
Contributor Author

hi @devArghya-0155 can you please check if it's responsive... it's breaking in every screen

references: image image image

I am working on these issues now.

@narayan954 narayan954 closed this Jun 17, 2024
@narayan954
Copy link
Owner

closed due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[style]: Changes in UI
2 participants