Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit contributing doc and update versions in pyproject.toml #137

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

willingc
Copy link

@willingc willingc commented Mar 9, 2025

No description provided.

@psobolewskiPhD psobolewskiPhD added this to the v0.1.5 milestone Mar 9, 2025
@psobolewskiPhD
Copy link
Member

Why isn't ruff fixing the Tuple and List, ...

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (3da07a3) to head (f6fe142).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   94.96%   94.97%           
=======================================
  Files          13       13           
  Lines        2107     2108    +1     
=======================================
+ Hits         2001     2002    +1     
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psobolewskiPhD
Copy link
Member

All the fails are pyside2 and typing incompatibility:
TypeError: unsupported operand type(s) for |: 'Shiboken.EnumType' and 'NoneType'
@Czaki how did we work around this in napari/napari?

@psobolewskiPhD
Copy link
Member

SO the issue is the pyside2 version on pypi (5.15.2.1) isn't compatible with python 3.10.
So we should drop that test condition.
However, 5.15.15 which is on conda-forge is compatible with 310 and 311 (but not 312 and 313). But the conda workflows are either not installing it from conda-forge or pinning to the pypi version incorrectly.

@psobolewskiPhD
Copy link
Member

Ok, i think the approach #140 will fix the tests here.

@psobolewskiPhD psobolewskiPhD added maintenance enhancement New feature or request labels Mar 15, 2025
@psobolewskiPhD
Copy link
Member

Took some re-runs due to seg faults from numpy 2.2 and pyside6.
I think this is good to go tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants