-
Notifications
You must be signed in to change notification settings - Fork 42
Edit testing doc and add admonition to Grzegorz blog post on Qt testing #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great changes. Was about to play with some testing things (to see if I can replicate the Windows seg faults on my PC), so will use this PR as the resource and report back.
Co-authored-by: Tim Monko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I like how the new change allows us to evolve by pointing to the necessary page, and not having to maintain the material in two places. Thanks!!
CI error for docs build is unrelated to this PR. |
not sure how to retrigger circleCI action? I'll just update branch |
I will say Circle was being finnicky early when I was merging into napari/napari |
Thanks @TimMonko. For the future, you can click through to the Circle CI dashboard and the upper right has a button to rerun Circle CI. |
Appreciate YOU @willingc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @willingc
References and relevant issues
Closes #494
Description
This PR edits the testing page. After reviewing each section, I added
information that would be helpful for contributors. An admonition was
added to reference Grzegorz' blog post on avoiding segfaults in Qt tests.
Also rearranged some sections like mocking to group common tasks before specifics.