Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate images of parts of the viewer #621
base: main
Are you sure you want to change the base?
Autogenerate images of parts of the viewer #621
Changes from 7 commits
2fb68c1
63e8387
11a111a
fe5f1b7
8072f05
d0e69d4
456cdb8
91cde7a
31e81d0
b2df727
70e7e03
0995949
3d8aec9
4326a74
70b3373
73c5ce1
e267262
c20d526
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a good solution. We need to find a way to define a list of popups to iterate over it.
Maybe global list and just pass the index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you look strictly at autogenerate-gui? I've put the most recent popup stuff in there. It's flaky, where sometimes it works and sometimes it doesn't, I've tried to include closing popups there, but yes, trying to work towards creating a list. Sorry I didn't remove this file 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in 2-3 hours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course! no issue, I'm actually going to plug along on it for about another hour, so you should receive a better file by then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your review did at least confirm some of the direction I thought it needed to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous popup is not closed before your code triggers creation of the next popup, so the first popup is captured again. We either need to use proper class in place of
QtPopup
or useobjectName()
method (with earlier setting it).