Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

Implements #108 #118

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Implements #108 #118

wants to merge 2 commits into from

Conversation

narJH27
Copy link

@narJH27 narJH27 commented Apr 11, 2017

Implements #108

mirceaulinic
mirceaulinic suggested changes Apr 20, 2017
View reviewed changes
test/unit/mocked_data/test_get_interfaces_ip/normal/expected_result.json
@@ -9,20 +9,24 @@
"BVI10": {
"ipv4": {
"192.168.0.1": {
"prefix_length": 21
"prefix_length": 21,
"primary_ip": True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is valid JSON. Should be true instead of True.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, True will b0rk.

@mirceaulinic mirceaulinic added this to the APPROVED milestone Apr 20, 2017
@mirceaulinic mirceaulinic modified the milestones: BLOCKED, APPROVED Apr 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbarrosop dbarrosop dbarrosop left review comments

@mirceaulinic mirceaulinic mirceaulinic requested changes

Assignees
No one assigned
Labels
api_change enhancement
Projects
None yet
Milestone
BLOCKED
Development

Successfully merging this pull request may close these issues.
3 participants
@narJH27 @dbarrosop @mirceaulinic