fix get_facts, get_interface, get_interface_ip #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new code failed the Checks i have included recently. It's failing in Black format check. As napalm original project, we have included Black formatter check to this project, please format the code using Black formatter and push the code again. We appreciate your contribution to this project. |
|
Good afternoon, @codingnetworksb. Okay, I'll get to that soon |
|
Good afternoon, @codingnetworksb. i'm formatted the code using black |
|
Good afternoon, @codingnetworksb, haven't seen the changes? |
|
@vladislav-tenishchev I'm jumping into this now, and I'm happy to help you here. Do you mind adding a unit test to cover the additions please? Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good afternoon!
Conflict resolution didn't go according to plan, so I created a new repository and put my fixes there.
I would like to present some fixes for the library. In particular, fixing the duplication of the Dialer interface in the get_interfaces output, also for this interface, the ip address is now displayed. Also provided get_facts fixes for huawei AR and NE devices. If you consider including this pull request in the master branch, I would appreciate it.