Skip to content

[build] F: Pin newlib to _do_start-weak commit, restore reproducible newlib checkout #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
esaurez wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[build] F: Pin newlib to _do_start-weak commit, restore reproducible newlib checkout #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
# Pinned commits for each component.
ARG BINUTILS_COMMIT=686c3b0673c89fae3d03ee22a9d9ac9ce29bfa75
ARG GCC_COMMIT=d6995f34118ad2a5ed2f0408a3a8af44568bf2ee
ARG NEWLIB_COMMIT=e12d84a6789c07f938db4f6440ea0b427914c735
# Pinned to the merge commit of nanvix/newlib#17 ("[libc] F: Weaken
# _do_start so libnvx_crt0.a can override it cleanly"). Update this
# SHA to the upstream merge commit before merging the present PR.
ARG NEWLIB_COMMIT=881840f880350e6fd929629cef9a5a3d1708bbf4
ARG NEWLIB_BRANCH=dev

ENV PREFIX=/opt/nanvix
Expand All @@ -61,9 +64,14 @@ RUN git clone https://github.com/nanvix/binutils /build/binutils && \
RUN git clone https://github.com/nanvix/gcc /build/gcc && \
cd /build/gcc && git checkout ${GCC_COMMIT}

# Clone Newlib.
RUN git clone --branch ${NEWLIB_BRANCH} --single-branch --depth=1 \
https://github.com/nanvix/newlib /build/newlib
# Clone Newlib and pin to ${NEWLIB_COMMIT} (prior versions of this
# Dockerfile cloned with --depth=1 only and silently used the tip of
# ${NEWLIB_BRANCH} regardless of the declared pin, which made the
# build non-reproducible). Fetching with sufficient depth and then
# checking out ${NEWLIB_COMMIT} restores the pin.
RUN git clone --branch ${NEWLIB_BRANCH} \
https://github.com/nanvix/newlib /build/newlib && \
cd /build/newlib && git checkout ${NEWLIB_COMMIT}

# Build Binutils.
RUN cd /build/binutils && \
Expand Down
Loading