Skip to content
This repository was archived by the owner on Jun 24, 2026. It is now read-only.

Remove release override#173

Merged
ppenna merged 1 commit into
mainfrom
feat/remove-release-override
Jun 24, 2026
Merged

Remove release override#173
ppenna merged 1 commit into
mainfrom
feat/remove-release-override

Conversation

@ada-x64

@ada-x64 ada-x64 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Removes the redundant release override. Towards zutils#191

Copilot AI review requested due to automatic review settings June 8, 2026 20:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the PosixTestsBuild.release() override in .nanvix/z.py, relying on the inherited ZScript.release() behavior instead. This aligns with the effort in nanvix/zutils#191 to refactor/decouple the release verb from the ZScript API surface.

Changes:

  • Removed the repository-specific release() override that primarily delegated to super().release().
  • Removed the Windows-specific warning/early-return behavior previously implemented in that override.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ada-x64 ada-x64 marked this pull request as ready for review June 8, 2026 20:34
@ada-x64 ada-x64 requested a review from ppenna as a code owner June 8, 2026 20:34
@ada-x64 ada-x64 force-pushed the feat/remove-release-override branch from b1bd0ba to d1408c7 Compare June 10, 2026 15:15
Copilot AI review requested due to automatic review settings June 15, 2026 18:19
@ada-x64 ada-x64 force-pushed the feat/remove-release-override branch from d1408c7 to 24613c3 Compare June 15, 2026 18:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ppenna ppenna self-assigned this Jun 16, 2026
Removes the redundant release override. Towards zutils#191
@ppenna ppenna force-pushed the feat/remove-release-override branch from 24613c3 to e7e1cac Compare June 24, 2026 05:44
@ppenna ppenna merged commit 8393ff1 into main Jun 24, 2026
13 checks passed
@ppenna ppenna deleted the feat/remove-release-override branch June 24, 2026 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants