Remove bespoke windows CI test job#314
Merged
Merged
Conversation
This commit aims to remove the bespoke windows CI job. It also relaxes the _ensure_ramfs sentinel in CI. The ramfs image is built on a previous run and is guaranteed to be a valid and up-to-date image.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the repository-specific Windows CI test job and shifts Windows testing responsibility to the shared nanvix-ci.yml workflow in nanvix/workflows, while adjusting ramfs handling to rely on the standard test output location.
Changes:
- Remove the bespoke
windows-testjob from.github/workflows/ci.ymland enable Windows testing via the shared workflow input. - Remove
NANVIX_PREBUILT_RAMFShandling from.nanvix/src/test.pyso standalone tests always use_ensure_ramfs(). - Add a CI-only short-circuit in
.nanvix/src/build.pyto accept an existingnanvix_rootfs.imgwithout sentinel/hash validation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .nanvix/src/test.py | Removes prebuilt-ramfs override path and always ensures a ramfs for standalone tests. |
| .nanvix/src/build.py | Adds CI-specific reuse path for nanvix_rootfs.img in _ensure_ramfs(). |
| .github/workflows/ci.yml | Removes custom Windows test job and switches to shared workflow Windows testing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| self._ramfs_img = p | ||
| else: | ||
| self._ensure_ramfs(sysroot) | ||
| self._ensure_ramfs(sysroot) |
Comment on lines
84
to
+88
| """Validate that an up-to-date ramfs image exists. | ||
|
|
||
| Used by ``test``, ``release``, and ``benchmark``: never builds. | ||
| Building the ramfs requires Docker (for .pyc pre-compilation) | ||
| and is therefore confined to ``./z build`` via | ||
| :meth:`_build_ramfs`. A missing or stale image is fatal. | ||
| Used by ``test``, ``release``, and ``benchmark``: never builds. Building | ||
| the ramfs requires Docker (for .pyc pre-compilation) and is therefore | ||
| confined to ``./z build`` via :meth:`_build_ramfs`. A missing or stale |
ppenna
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the bespoke windows CI test job. This has been moved to the shared nanvix-ci.yml in nanvix/workflows.
This additionally removes the sentinel check for CI mode if the image exists.
Closes #276
Release artifacts should be unaffected by these changes.