Build test output to test_out#309
Closed
ada-x64 wants to merge 1 commit into
Closed
Conversation
ada-x64
changed the base branch from
fix/304/release-to-standard-location
to
main
ada-x64
force-pushed
the
fix/308/normalize-build-output
branch
from
d642bb8 to
f9426af
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the standalone ramfs test image output from nanvix_root() into test_out() and updates the Windows CI job to place/expose the extracted Linux-built ramfs in the new normalized output directory, aligning with issue #308’s goal of consolidating test build outputs.
Changes:
- Write the generated
nanvix_rootfs.imgand its.ramfs-builtsentinel intotest_out(). - Ensure
test_out()exists during ramfs builds (mkdir(parents=True, exist_ok=True)). - Update Windows CI to copy the extracted ramfs to
.nanvix/out/test/nanvix_rootfs.imgand exportNANVIX_PREBUILT_RAMFSaccordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .nanvix/src/clean.py | Cleans ramfs artifacts from the new test_out() location (but currently doesn’t clean legacy locations). |
| .nanvix/src/build.py | Builds/validates ramfs from test_out() (but still writes some ramfs build byproducts outside test_out()). |
| .github/workflows/ci.yml | Updates Windows CI to place the extracted ramfs in the new normalized output path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return img | ||
|
|
||
| stripped = work_dir / "stripped-sysroot" | ||
| stripped = nanvix_root() / "stripped-sysroot" |
|
|
||
| # Generate build manifests for post-build inspection | ||
| self._write_build_manifests(sysroot, stripped, work_dir) | ||
| self._write_build_manifests(sysroot, stripped, nanvix_root()) |
Comment on lines
+32
to
35
| ramfs_img = test_out() / "nanvix_rootfs.img" | ||
| ramfs_img.unlink(missing_ok=True) | ||
| ramfs_sentinel = nanvix_root() / ".ramfs-built" | ||
| ramfs_sentinel = test_out() / ".ramfs-built" | ||
| ramfs_sentinel.unlink(missing_ok=True) |
ada-x64
force-pushed
the
fix/308/normalize-build-output
branch
from
f9426af to
86eb9c5
Compare
| return img | ||
|
|
||
| stripped = work_dir / "stripped-sysroot" | ||
| stripped = nanvix_root() / "stripped-sysroot" |
Comment on lines
+121
to
+125
| work_dir = test_out() | ||
| img = work_dir / "nanvix_rootfs.img" | ||
| sentinel = work_dir / ".ramfs-built" | ||
| current_hash = self._ramfs_input_hash(sysroot) | ||
| work_dir.mkdir(parents=True, exist_ok=True) |
Comment on lines
31
to
35
| self._cleanup_ramfs() | ||
| ramfs_img = nanvix_root() / "nanvix_rootfs.img" | ||
| ramfs_img = test_out() / "nanvix_rootfs.img" | ||
| ramfs_img.unlink(missing_ok=True) | ||
| ramfs_sentinel = nanvix_root() / ".ramfs-built" | ||
| ramfs_sentinel = test_out() / ".ramfs-built" | ||
| ramfs_sentinel.unlink(missing_ok=True) |
Comment on lines
151
to
+152
| # Generate build manifests for post-build inspection | ||
| self._write_build_manifests(sysroot, stripped, work_dir) | ||
| self._write_build_manifests(sysroot, stripped, nanvix_root()) |
Comment on lines
+808
to
+811
| elf_out = repo_root() / "elf-binaries" | ||
| if elf_out.exists(): | ||
| shutil.rmtree(elf_out) | ||
| elf_out.mkdir() |
Builds ramfs test image to test_out. Updates windows CI job to match. Closes #308.
ada-x64
force-pushed
the
fix/308/normalize-build-output
branch
from
86eb9c5 to
df3f698
Compare
ada-x64
changed the base branch from
main
to
fix/304/release-to-standard-location
Contributor
Author
|
Closing to recreate with linear stack ordering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds ramfs test image to test_out. Updates windows CI job to match.
Closes #308.