Rm release override#100
Merged
Merged
Conversation
Removes the redundant release override. Towards zutils#191
There was a problem hiding this comment.
Pull request overview
Removes the custom release() override from the Nanvix build script now that nanvix-zutil v0.12.0’s base ZScript.release() already generates release archive names using the build-configuration suffix pattern, avoiding CI asset collisions.
Changes:
- Dropped the
LibxsltBuild.release()override and its associated imports. - Relied on upstream
ZScript.release()behavior for release packaging/naming.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ppenna
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the redundant release override; the base
ZScript.release()in nanvix-zutil v0.12.0 already implements the same suffix-naming pattern ({name}-{machine}-{deployment_mode}-{memory_size}).Verified the full lifecycle on Linux and Windows before and after the change: release archive filenames and contents match.
Towards nanvix/zutils#191.