refactor: remove archive format monkey-patches (zutils 0.8.2)#26
Merged
Conversation
zutils v0.8.2 natively handles .tar.gz, .tar.bz2 and .zip
archives via tarfile.open("r:*") and zipfile.is_zipfile().
Remove the setup() overrides that monkey-patched tarfile.open
to work around the old hardcoded r:bz2 extraction mode.
There was a problem hiding this comment.
Pull request overview
This PR removes the local setup() override in the Nanvix build helper script now that nanvix-zutil v0.8.2 can natively handle .tar.gz, .tar.bz2, and .zip archives without needing monkey-patches.
Changes:
- Removed the
setup()method override that rewrote dependency artifact patterns and temporarily monkey-patchedtarfile.open. - Relies on upstream nanvix-zutil archive detection/extraction behavior instead of local workarounds.
Show a summary per file
| File | Description |
|---|---|
| .nanvix/z.py | Deletes the custom setup() monkey-patching logic and falls back to the base ZScript.setup() implementation. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zutils v0.8.2 natively handles
.tar.gz,.tar.bz2and.ziparchives viatarfile.open("r:*")andzipfile.is_zipfile().Remove the
setup()overrides that monkey-patchedtarfile.opento work around the old hardcodedr:bz2extraction mode.