[libxml2] Migrate to Nanvix SDK#111
Merged
Merged
Conversation
Build against the verified Clang SDK and SDK-built zlib while keeping downloaded Nanvix artifacts runtime-only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a354ddf-0f65-44b2-a2cb-81d4662a3587
There was a problem hiding this comment.
Pull request overview
This PR updates the Nanvix port of libxml2 to build against the Nanvix Clang/LLVM SDK (v0.20.0), consuming zlib from the Nanvix buildroot, and adjusts CI/docs to match the new toolchain and target support.
Changes:
- Switch Nanvix build + CI to a pinned Nanvix Clang SDK container digest and require buildroot-provided headers/libs (zlib).
- Update Nanvix target metadata to Nanvix v0.20.0 and microvm-only builds at 256MB.
- Emit relocatable Nanvix
xml2-configandpkg-config(libxml-2.0.pc) artifacts as part of the staged outputs.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents Nanvix SDK pin, build commands, and microvm-only runtime constraints for v0.20.0. |
| .nanvix/z.py | Pins default SDK docker image, enforces buildroot presence, and stages xml2-config + .pc outputs. |
| .nanvix/nanvix.toml | Bumps Nanvix version to 0.20.0 and limits build matrix to microvm. |
| .nanvix/Makefile.nanvix | Migrates to SDK clang/llvm-* tools and generates relocatable xml2-config/libxml-2.0.pc. |
| .github/workflows/nanvix-ci.yml | Updates CI to use the pinned Nanvix Clang SDK docker image digest. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Low
Comment on lines
+97
to
+103
| @echo '#!/bin/sh' > $(BIN_OUT)/xml2-config | ||
| @echo 'prefix=$$(CDPATH= cd -- "$$(dirname -- "$$0")/.." && pwd)' >> $(BIN_OUT)/xml2-config | ||
| @echo 'case "$$1" in' >> $(BIN_OUT)/xml2-config | ||
| @echo ' --cflags) echo "-I$$prefix/include/libxml2" ;;' >> $(BIN_OUT)/xml2-config | ||
| @echo ' --libs) echo "-L$$prefix/lib -lxml2 -lz" ;;' >> $(BIN_OUT)/xml2-config | ||
| @echo ' --version) echo "2.12.9" ;;' >> $(BIN_OUT)/xml2-config | ||
| @echo 'esac' >> $(BIN_OUT)/xml2-config |
Comment on lines
+105
to
+107
| @echo 'prefix=$${pcfiledir}/../..' > $(LIB_OUT)/pkgconfig/libxml-2.0.pc | ||
| @echo 'libdir=$${prefix}/lib' >> $(LIB_OUT)/pkgconfig/libxml-2.0.pc | ||
| @echo 'includedir=$${prefix}/include' >> $(LIB_OUT)/pkgconfig/libxml-2.0.pc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local validation