Drop single-process and multi-process deployment modes; keep only standalone#109
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
ppenna
July 10, 2026 15:56
View session
ppenna
marked this pull request as ready for review
July 10, 2026 15:59
There was a problem hiding this comment.
Pull request overview
This PR updates the Nanvix build/CI integration to remove the single-process and multi-process deployment modes from the repo’s configuration and CI matrix, leaving standalone as the only intended execution path.
Changes:
- Restricts the Nanvix build matrix to
modes = ["standalone"]. - Updates the GitHub Actions Nanvix CI workflow inputs to run only
standalone. - Simplifies
.nanvix/z.pytest execution to always run the standalone functional test path.
Show a summary per file
| File | Description |
|---|---|
.nanvix/z.py |
Removes non-standalone test routing and simplifies Windows test logic for the standalone-only workflow. |
.nanvix/nanvix.toml |
Drops single-process and multi-process from the build matrix, leaving only standalone. |
.github/workflows/nanvix-ci.yml |
Updates CI workflow inputs (process-modes, skip-full-test-modes) to only include standalone. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Low
Comment on lines
+174
to
+175
| self._validate_test_targets() | ||
| self._run_functional_standalone() |
| ) | ||
| return | ||
|
|
||
| sysroot_path = Path(self._get_sysroot()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
single-processandmulti-processNanvix deployment modes from the build/CI tooling, leavingstandaloneas the only supported mode.Changes
.nanvix/nanvix.toml— Build matrixmodes = ["standalone"]..github/workflows/nanvix-ci.yml—process-modesandskip-full-test-modesset to["standalone"]in both theciandci-scheduledjobs..nanvix/z.pytest()— dropped the non-standaloneelsebranch that routed multi/single-process modes through the Makefile test targets; non-Windows now always runs the standalone functional test._run_tests_windows()— removed the "skip if not standalone" guard and the docstring naming the dropped modes.Intentionally untouched
.nanvix/Makefile.nanvixuses a generic$(PROCESS_MODE)(now alwaysstandalone), never names the dropped modes, and is still used by thebuild/installtargets. Removing its now-unused test targets would orphan the genericPLATFORM/PROCESS_MODE/MEMORY_SIZErequired vars, which are unrelated to the modes being dropped.Notes
deployment_modedefaults tostandaloneinnanvix-zutil, and the standalone Linux/Windows test paths already bypass the Makefile, so CI (Linux + Windows) and local./z build/./z testbehavior for standalone is unchanged.