[ci] E: Update nanvix workflow refs to v2.3.0#264
Merged
Conversation
`nanvix/workflows@v2.3.0` (commit f06ad3f) tightened the windows-test
artifact upload contract to `${test-output-path}/**/*.{elf,so}` with
default `.nanvix/out/test`, and downloads the artifact back into the
same path on the Windows runner before running `./z test`.
libffi's build side is already correct: `Makefile.nanvix install`
copies `ffi_test.elf` into `TEST_OUT` (which `_make_args` passes as
`test_out()`), and `_staged_output_files()` lists it for the Windows
docker copy-back. The upload glob already catches the file.
The only missing piece is the test-side discovery: `_run_tests_windows`
searched `[repo_root(), repo_root()/build]` -- neither of which exists
on the Windows runner where the artifact lands in `test_out()`.
This commit prepends `test_out()` to the candidate list. The existing
per-binary staging block (copy to repo_root() for `make_initrd`'s
zutils-v0.13.0 hardcoded path, cleanup in `finally`) already handles
the rest, including refusing to clobber a pre-existing repo-root file.
Verified with `just lc --platform=linux` and
`just lc --platform=windows-ci` (both green; `windows-ci_test exit=0`).
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Nanvix CI integration to use nanvix/workflows@v2.3.0 and adjusts the Windows test runner’s ELF discovery/staging behavior to align with the canonical workflow artifact layout.
Changes:
- Bump
nanvix/workflowsreusable workflow reference fromv2.2.0tov2.3.0. - Update Windows test binary discovery order to prefer
.nanvix/out/test/before falling back to repo-root/build locations. - Adjust repo-root ELF staging logic for
make_initrdduring Windows tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.nanvix/z.py |
Changes Windows test binary discovery/staging to prefer test_out() and tweaks repo-root copy/cleanup behavior. |
.github/workflows/nanvix-ci.yml |
Updates reusable workflow ref to nanvix/workflows/.github/workflows/nanvix-ci.yml@v2.3.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+316
to
+320
| # `staged_created` is False whenever the repo-root copy | ||
| # pre-existed (e.g. a dev's prior `./z build` left it | ||
| # there alongside the install copy in `test_out()`), so | ||
| # cleanup never deletes a developer's build output. | ||
| # Parity with bzip2/openssl. |
Comment on lines
+321
to
+323
| preexisted = repo_elf.exists() | ||
| shutil.copy2(binary, repo_elf) | ||
| copied_elf = True | ||
| copied_elf = not preexisted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated bump of
nanvix/workflowsreferences tov2.3.0.Generated by the Update Workflow Refs workflow.