[Draft] A new p-value enabled DetectionStatistic class#254
Open
vhaasteren wants to merge 15 commits into
Open
Conversation
vhaasteren
changed the title
Member
Author
|
Hi @AaronDJohnson , any chance you can give this a quick review? My p-value paper is entering production. It's not a pretty class, but it may be suitable for e_e |
…istics (missed git commit from a while ago)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in implementation of the Optimal Detection statistic the way it was derived in van Haasteren (2025) "On the calculation of p-values in Pulsar Timing Arrays", which includes the efficient implementation of the generalized Chi-squared distribution.