update: chromatic noise models & feat: hypermodel empirical distributions#242
Conversation
merging master in
…l for dm_gp and chrom_gp
Adding option to set dt
…aw prior -- not the number of fourier modes
paulthebaker
left a comment
There was a problem hiding this comment.
Consider making the minor changes suggested
| sign_param = parameter.Constant() | ||
| elif sign == "positive": | ||
| sign_param = 1.0 | ||
| else: |
There was a problem hiding this comment.
same as above: elif sign == "negative", and optionally raise a ValueError in a final else
|
If you have to make any changes, it should be trivial to fix issue #260 while you are at it. |
|
@blarsen10 is going to add one more thing. and we are finalizing compatibility tests. so please don’t merge quite yet, @paulthebaker . but otherwise, I think that things are in order. |
|
@paulthebaker i think all of the code for this PR is now finalized actually. i want to spend a few hours this afternoon doing some last minute checks, but then it should be ready for merge. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 37.29% 34.48% -2.82%
==========================================
Files 20 23 +3
Lines 3974 4759 +785
==========================================
+ Hits 1482 1641 +159
- Misses 2492 3118 +626
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
paulthebaker
left a comment
There was a problem hiding this comment.
Please use enterprise.constants module when applicable for easier human readability
This PR contains many various updates associated with chromatic noise modeling efforts over the past several years.
Notable changes include:
model_log_weights.json)