Skip to content

Conversation

@vhaasteren
Copy link
Member

Let N be the white noise kernel (marginalizingNmat, ShermanMorrison, ndarray_alt, ...). The solve(x) method would calculate N^{-1}x. Assume that LL^T=N with L a Cholesky factor. Then the new sqrtsolve(x) would return L^{-1}x

This PR implements that

@vhaasteren vhaasteren changed the base branch from master to dev April 21, 2025 04:44
@vhaasteren vhaasteren changed the title Add sqrtN for sherman-morrison and white noise kernels Add sqrtN solve for sherman-morrison and white noise kernels Apr 21, 2025
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

❌ Patch coverage is 65.51724% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.47%. Comparing base (e04d9d4) to head (9264b2c).
⚠️ Report is 27 commits behind head on dev.

Files with missing lines Patch % Lines
enterprise/signals/gp_signals.py 15.38% 11 Missing ⚠️
enterprise/signals/signal_base.py 80.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #419      +/-   ##
==========================================
- Coverage   72.53%   71.47%   -1.07%     
==========================================
  Files          13       13              
  Lines        3401     3306      -95     
==========================================
- Hits         2467     2363     -104     
- Misses        934      943       +9     
Files with missing lines Coverage Δ
enterprise/signals/signal_base.py 89.73% <80.00%> (-1.78%) ⬇️
enterprise/signals/gp_signals.py 65.59% <15.38%> (-5.55%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a258b...9264b2c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vhaasteren
Copy link
Member Author

Hi @AaronDJohnson, any chance you can give this a quick review? My p-value paper is entering production

Copy link
Collaborator

@AaronDJohnson AaronDJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! This looks good.

@vhaasteren vhaasteren merged commit 64780f4 into nanograv:dev Nov 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants