Chromatic Gaussian event model#1980
Conversation
|
@davidkaplantest |
|
I'll start taking a peak at this. Note that the docs render well: |
|
I see differences in the parameters and the analytical form (no sign in the form, amplitude is not log10). Can you connect the analytic expression with the parameters more explicitly? |
I can look at this, but I'd say that if you've gotten the fitting to work then that's a good sign that the derivatives are correct (or at least close enough). |
Oh hey, I didn’t know you could access the docs build like that. Super handy. Thanks. I will plan to rewrite the docs so that it matched the parameters themselves. |
Great. Note that it can be frustrating to check the builds since it takes an ~hour for GitHub to do it. If you really want to dig into that I can give you instructions for doing a local build which can help iterate faster. |
Injected vs. Recovered Parameters
|
|
I think this is ready for a final review 🤠 |
That's looking pretty good. But what are the 3 different plots (or presumably the last is post-fit resids, so what are the first two)? |
The docs are looking good. Nice to show an example. Can you also maybe show how that looks in the par file (print a subsection of the model object, or similar)? I am curious just because this is new, so I don't know the standard form. |
|
This is what the model looks like if I print the par file: |
Nice. Can you include that in the docs? |
|
So I think this looks largely good. Like I said I haven't verified all of the partial derivatives in detail, but the fact that fits largely converge is good. I personally am probably happy to merge it but I don't know if anybody else (@abhisrkckl, @mtlam ) wants to look |
|
Minor comments:
|
The model that Reardon et al fit is dispersive:
Looks like they just don’t really write the model equation up properly. I cited Coles in the docstring because they report on extreme scattering events in pulsar timing data. They don’t use a Gaussian model there as far as I see. I will plan to update the docstring to be more clear there. Something like “See Coles et al 2015 for more details on extreme scattering events." |
|
Note that K is not the dm constant but just 1400 MHz so this matches the implementation here exactly I think. |
|
I updated the docstring according to @mtlam ’s suggestion. |
|
Checking in on this. @dlakaplan @mtlam |
|
Things look fine to me. |
|
Thanks to you both for taking a look at this ! |




Adds a transient chromatic Gaussian event model as a delay signal. See https://iopscience.iop.org/article/10.3847/2041-8213/acdd03/pdf for details on the model, but note a typo missing the negative sign in the definition of the Gaussian.
Derivatives checked here:
https://www.wolframcloud.com/obj/f6b351f0-5c17-4777-ab4e-fd0f6ff03c41