Added standalone ENSAdmin for Railway/Render #1017

BanaSeba · 2025-09-04T20:24:17Z

Update Railway ENSAdmin version on deploy
Add ENSAdmin on Render

changeset-bot · 2025-09-04T20:24:21Z

⚠️ No Changeset found

Latest commit: 3f21b37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-09-04T20:24:25Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
admin.ensnode.io	Ready	Preview	Comment	Sep 6, 2025 2:08pm
ensnode.io	Ready	Preview	Comment	Sep 6, 2025 2:08pm
ensrainbow.io	Ready	Preview	Comment	Sep 6, 2025 2:08pm

lightwalker-eth

@BanaSeba Excited to see this as it's a key priority! Reviewed and shared feedback 👍

lightwalker-eth · 2025-09-04T21:08:26Z

terraform/main.tf

+  render_region         = local.render_region
+  render_environment_id = render_project.ensnode.environments["default"].id
+  instance_type         = "starter"
+


What about environment variables that ENSAdmin uses?

See: https://github.com/namehash/ensnode/blob/main/apps/ensadmin/.env.local.example

Shouldn't all 3 of those be referenced here in some way?

Added ANTHROPIC_API_KEY . NEXT_PUBLIC_DEFAULT_ENSNODE_URLS is not working for Docker images. We will need to fix it first. Not sure if the name will still be the same

Where can I find a GitHub issue to track the issue with supporting NEXT_PUBLIC_DEFAULT_ENSNODE_URLS in Docker images?

I've created the issue for that

lightwalker-eth · 2025-09-04T21:11:31Z

terraform/modules/ensadmin/dns.tf

@@ -0,0 +1,16 @@
+locals {
+  full_ensadmin_hostname = "ensadmin.${var.subdomain_prefix}.${var.base_domain_name}"


There's a number of places where I see us write terminology such as "full ... hostname", etc..

My understanding is that the correct technical term for this is "fully qualified domain name" or "fqdn" as an abbreviation.

Suggest to refine naming across our terraform scripts to make use of "fqdn" where relevant. You're welcome to action this idea in this PR or to create a new GitHub issue for it and follow up later in a separate PR.

Changed to fqdn

lightwalker-eth · 2025-09-04T21:12:22Z

terraform/modules/ensadmin/main.tf

+      tag       = var.ensnode_version
+    }
+  }
+


What about environment variables that ENSAdmin uses?

See: https://github.com/namehash/ensnode/blob/main/apps/ensadmin/.env.local.example

Shouldn't all 3 of those be referenced here in some way?

Added ANTHROPIC_API_KEY . NEXT_PUBLIC_DEFAULT_ENSNODE_URLS is not working for Docker images. We will need to fix it first. Not sure if the name will still be the same

lightwalker-eth · 2025-09-04T21:13:17Z

terraform/modules/ensadmin/main.tf

+    }
+  }
+
+  custom_domains = [


Could you please add a comment explaining what this custom_domains idea is about?

Added Domains assigned by user

Please see related feedback on the same idea in another file

lightwalker-eth · 2025-09-04T21:14:54Z

terraform/modules/ensadmin/outputs.tf

@@ -0,0 +1,3 @@
+output "ensadmin_url" {


Is this related to the ENSADMIN_PUBLIC_URL environment variable?

Assuming so, we should give it the same name. Ex: ensadmin_public_url. The "public" in this context is a hint how the URL needs to be usable for the public internet and not a private network.

Changed to ensadmin_public_url

lightwalker-eth · 2025-09-04T21:16:25Z

terraform/modules/ensadmin/variables.tf

+  type = string
+}
+
+# DNS configuration


Please add more documentation for this DNS configuration. It's not clear to me what it's really used for / what purpose or consequence it has.

This comment applies to both the base_domain_name and subdomain_prefix fields.

Added more comments

Thanks. That helps. Please see related feedback on how we name these fields in another file.

lightwalker-eth

@BanaSeba Thanks for updates. Reviewed and shared feedback

lightwalker-eth · 2025-09-08T23:41:45Z

terraform/modules/ensindexer/main.tf

      },
      ENSINDEXER_URL = {
        value = "http://ensindexer-${var.instance_name}:10000"
      }
    }
  )
+  # Domains assigned by user


I'm completely lost when I read this comment. Please put more effort into these comments.

Who is the user?

What does it mean to assign a domain in this context?

Assign a domain to what?

For what purpose does this logic exist?

Why are these called "custom_domains"?

lightwalker-eth · 2025-09-08T23:45:11Z

terraform/variables.tf

@@ -19,6 +19,9 @@ variable "ensdb_disk_size_gb" {
  type    = number
  default = 250
 }
+variable "anthropic_api_key" {


Is there a way to define which variables are optional?

For example, "anthropic_api_key" should be optional.

lightwalker-eth · 2025-09-08T23:46:27Z

terraform/variables.tf

@@ -19,6 +19,9 @@ variable "ensdb_disk_size_gb" {
  type    = number
  default = 250
 }
+variable "anthropic_api_key" {


This variable is only relevant for ENSAdmin. It would be nice to document that here. It shouldn't be listed under "General Variables"

lightwalker-eth · 2025-09-08T23:49:12Z

terraform/modules/ensindexer/main.tf

@@ -96,7 +98,7 @@ resource "render_web_service" "ensindexer_api" {
    local.common_variables,
    {
      ENSNODE_PUBLIC_URL = {
-        value = "https://${local.full_ensindexer_api_hostname}"
+        value = "https://${local.ensindexer_api_fqdn}"
      },
      ENSINDEXER_URL = {
        value = "http://ensindexer-${var.instance_name}:10000"


I'm finding this instance_name var unclear. Instance name for what exactly? The instance name of the ENSIndexer instance within 1 ENSNode deployment (that combines 1 api instance and 1 indexer instance)? Or is this the instance name of the ENSIndexer instance within an overall environment (such as the overall yellow environment)?

What is the possible range of values for instance_name?

lightwalker-eth · 2025-09-08T23:50:43Z

terraform/modules/ensindexer/main.tf

@@ -107,7 +109,7 @@ resource "render_web_service" "ensindexer_api" {
    }
  )
  custom_domains = [


Please see my related comments about custom_domains in another file.

We need to write all our code, including all our terraform code, so it has strong documentation and can be clearly understood by people who are new to the code and new to terraform.

I keep finding too many issues where these goals are failing.

lightwalker-eth · 2025-09-09T00:13:05Z

terraform/modules/ensadmin/main.tf

+    }
+  }
+
+  custom_domains = [


Please see related feedback on the same idea in another file

lightwalker-eth · 2025-09-09T00:14:15Z

terraform/modules/ensadmin/variables.tf

+  type = string
+}
+
+variable "anthropic_api_key" {


The anthropic api key shouldn't be listed under "# Render configuration"

lightwalker-eth · 2025-09-09T00:14:49Z

terraform/modules/ensadmin/variables.tf

+  type = string
+}
+
+# DNS configuration


Thanks. That helps. Please see related feedback on how we name these fields in another file.

lightwalker-eth · 2025-09-09T00:19:26Z

terraform/modules/ensindexer/main.tf

@@ -13,6 +13,7 @@ locals {
    "INDEX_ADDITIONAL_RESOLVER_RECORDS" = { value = var.index_additional_resolver_records },
    "HEAL_REVERSE_ADDRESSES"            = { value = var.heal_reverse_addresses },
    "REPLACE_UNNORMALIZED"              = { value = var.replace_unnormalized },
+    "ENSADMIN_URL"                      = { value = var.ensadmin_public_url }


Hmm, why is ensadmin_public_url a completely customizable URL? Shouldn't we be able to build it up programmatically based on other variables? Or is there a special reason we have to do it this way?

lightwalker-eth · 2025-09-09T00:22:18Z

terraform/modules/ensindexer/variables.tf

@@ -45,6 +45,10 @@ variable "ensrainbow_url" {
  type = string
 }

+variable "ensadmin_public_url" {


Please see related comment asking why we can't deterministically build this URL out of other variables?

Added standalone ENSAdmin for Railway/Render

08ca694

BanaSeba requested a review from a team as a code owner September 4, 2025 20:24

vercel bot deployed to Preview – admin.ensnode.io September 4, 2025 20:24 View deployment

vercel bot deployed to Preview – ensrainbow.io September 4, 2025 20:25 View deployment

lightwalker-eth reviewed Sep 4, 2025

View reviewed changes

Post review fixes

7ba3042

vercel bot deployed to Preview – admin.ensnode.io September 6, 2025 13:24 View deployment

vercel bot deployed to Preview – ensnode.io September 6, 2025 13:25 View deployment

vercel bot deployed to Preview – ensrainbow.io September 6, 2025 13:25 View deployment

Terraform lint

3f21b37

vercel bot deployed to Preview – ensnode.io September 6, 2025 14:07 View deployment

vercel bot deployed to Preview – ensrainbow.io September 6, 2025 14:07 View deployment

vercel bot deployed to Preview – admin.ensnode.io September 6, 2025 14:08 View deployment

lightwalker-eth reviewed Sep 9, 2025

View reviewed changes

		@@ -0,0 +1,16 @@
		locals {
		full_ensadmin_hostname = "ensadmin.${var.subdomain_prefix}.${var.base_domain_name}"

Added standalone ENSAdmin for Railway/Render #1017

Are you sure you want to change the base?

Added standalone ENSAdmin for Railway/Render #1017

Uh oh!

Conversation

BanaSeba commented Sep 4, 2025

Uh oh!

changeset-bot bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lightwalker-eth left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lightwalker-eth left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

changeset-bot bot commented Sep 4, 2025 •

edited

Loading

vercel bot commented Sep 4, 2025 •

edited

Loading