Create an Ethereum bridge sub-crate#923
Merged
batconjurer merged 5 commits intoeth-bridge-integrationfrom Dec 20, 2022
Merged
Conversation
sug0
requested changes
Dec 19, 2022
Collaborator
sug0
left a comment
sug0
left a comment
There was a problem hiding this comment.
hm it's not as bad as I thought it'd be, but it'll probably still be annoying to rebase against haha
sug0
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors much of Ethereum bridge out of the
sharedcrate and into its own crate. The only things remaining in the shared crate are the implementations of the native VPs.The
QueriesExttrait has been moved toproof_of_stakeand been renamed toPosQueries.I was unable to lift any logic from
coreinto the new subcrate as it either related to storage or txs, both of which are appropriate incore.Note: we cannot use ferveo main until this PR is accepted