Update bootstrapDialog for Bootstrap version 4.0. by avan06 · Pull Request #281 · nakupanda/bootstrap3-dialog

avan06 · 2016-07-22T09:17:12Z

A modified version is downward compatible,

ellisio · 2016-08-04T18:37:34Z

As of the latest v4 Alpha release this no longer works. You get this error when compiling via Grunt:

Error: Cannot find module 'bootstrap' from '/Users/andrew/Developer/Kicka/Seminar/node_modules/bootstrap3-dialog/dist/js

This will be fixed in the v4-alpha-3.1 patch.

EugenMayer · 2016-08-10T08:35:29Z

Just to mention, also working on this, using @avan06 code https://github.com/EugenMayer/bootstrap-dialog and some additions like bower dependency fixes. I am the the middle of testing it against bootstrap-4dev and could join this to see how far we get this

EugenMayer · 2016-08-10T08:49:28Z

At least this EugenMayer#4 and that EugenMayer#1 would be needed to get some sort of working copy.

EugenMayer · 2016-08-10T12:00:05Z

created a jsfiddle with bootstrap 4 http://jsfiddle.net/o5k0eaws/217/

EugenMayer · 2016-08-10T15:36:21Z

i updated the jsfiddle to outline one issue:
Bootstrap 4: http://jsfiddle.net/o5k0eaws/219/
Bootstrap 3: http://jsfiddle.net/o5k0eaws/220/

In bootstrap3, the modal-backdrop handling works, so the first dialog is overlayed by the backdrop, in bootstrap it is not. The reason is, that the modal-backdrops do not get a z-index at all.

Using bootstrap4 with the classic API though, does work : http://jsfiddle.net/o5k0eaws/222/
So bootstrap 4 in general works with the classic API, but when using setModal it does not yet work

nakupanda · 2016-08-11T01:21:56Z

Thanks for this try for bootstrap 4, it's been long since last time folks talking about this.

I'm haven't read through bootstrap yet, I will arrange my time on it and them see how to create bootstrap 4-dialog.

EugenMayer · 2016-08-11T07:58:57Z

Well the only issue i am for now encountering is the one outlined in http://jsfiddle.net/o5k0eaws/219/ .. with the special use of bootstrap-dialog .. the modal-backdrop handling fails. Could you point me in a direction looking for thaT?

'choose_remote_name/revert-232-feature_mouseOverButton'

digixweb · 2017-03-08T16:08:14Z

I also get this error: "bootstrap3-dialog": "^1.35.3",

Browserify Failed!: Cannot find module 'bootstrap' from '/home/vagrant/dev/mbm/node_modules/bootstrap3-dialog/dist/js'

mediatvguy · 2017-04-12T17:14:27Z

Greetings from Florida :)

Any news on bootstrapDialog for V. 4 ?

EugenMayer · 2017-04-12T17:16:03Z

As much news as from bootstrap 4 itself, none

mediatvguy · 2017-04-12T17:17:08Z

:(

nakupanda · 2017-04-13T01:34:24Z

Sorry, none..

bindrid · 2017-08-19T17:48:00Z

Note: bootstrap 4 beta is now out. In there documentation, they do not support stacked modals as they consider it a bad user experience. https://getbootstrap.com/docs/4.0/components/modal/

bindrid · 2017-08-20T22:28:59Z

I got Avan06 's version working. I had to add "col" class to the three sections, header, body and footer.
I also put a float right on the footer button container.

    createHeaderContent: function () {
        var $container = $('<div></div>');
        $container.addClass(this.getNamespace('header') + " col");

Oviglo · 2017-08-21T11:09:47Z

+1

nakupanda · 2017-08-23T08:11:33Z

@bindrid in bs3 it's also suggested not to use stacked modals.

alpertandogan · 2017-09-04T09:00:40Z

in css file i made this modification for bootstrap 4

.bootstrap-dialog .bootstrap-dialog-footer-buttons .btn{
margin-right: 5px;
}
.bootstrap-dialog .bootstrap-dialog-footer-buttons .btn:last-child{
margin-right: 0;
}

tmaly1980 · 2017-11-18T11:27:52Z

FYI, bootstrap-v4.0.0-beta.2 is out. @nakupanda Why is this sitting around for months? This library is essential IMO for modals so I don't have to actually code the HTML manually.

EugenMayer · 2017-11-18T17:42:22Z

@tmaly1980 don't hold yourself back, go forward and do the essential work?

tmaly1980 · 2017-12-08T09:49:35Z

@EugenMayer It looks like it's been done already, by @avan06 . Merge request has been sitting around since August.

Also looks like you did some work on this in your own cloned repo. How far did you get?

l0ft13 · 2018-01-18T06:06:41Z

+1

Oviglo · 2018-03-01T14:58:42Z

Thank you !

Jako · 2018-03-13T07:41:00Z

It would be nice, if the work of @avan06 could be included here.

leankuroneko · 2018-03-13T13:12:25Z

Indeed! I had to remove the plugin because Yii updated Bootstrap and the functionality loss is noticeable :(

TCardinal · 2018-04-05T09:20:52Z

it would be good to get this merged now. holding things up.

leankuroneko

I tested this fix. It solves compatibility and although some css issues appear, it makes the plugin usable again.

Oviglo · 2018-04-28T15:29:51Z

Do you try with the last version of Bootstrap (4.1) ? I have this error:

Uncaught TypeError: Cannot set property 'paddingRight' of undefined

"element" var seem to be a jQuery object but it call native 'css' attribute

EDIT: Ok I think it's normal, just add 4.1 version :)

rmihaig · 2018-06-02T20:20:04Z

Hello,
I managed to make this work with 4.1 by changing this line
} else if (/4.0.\d+/.test($.fn.modal.Constructor.VERSION)) { //FIXME for BootstrapV4
with this one
} else if (/4.\d+/.test($.fn.modal.Constructor.VERSION)) { //FIXME for BootstrapV4

GedMarc · 2018-06-08T20:22:28Z

+1 !
:)

alcidesfmelof · 2018-06-13T11:52:42Z

Ho can I download a version that works with bootstrap 4.1?

GedMarc · 2018-06-13T12:17:54Z

I took all the changes and applied them, if you just want quick js files can grab these https://github.com/GedMarc/Bootstrap-Dialog4/tree/master/jar-resources/META-INF/resources/bower_components/bootstrap4-dialog/dist/js

JavaTMP · 2018-06-13T17:59:05Z

We created Bootstrap modal Wrapper plugin for bootstrap 4.1 that does not depends on any external CSS other than standard bootstrap css file which supports dynamic and stack modal creations in this repository https://github.com/JavaTMP/bootstrap-modal-wrapper

GedMarc

There are more places that require updates 👍
BootstrapDialogModal.METHODS_TO_OVERRIDE['v4.1'] = $.extend({}, BootstrapDialogModal.METHODS_TO_OVERRIDE['v3.3']);

Add at line 148, maybe with the \d?

GedMarc · 2018-06-18T08:53:18Z

https://github.com/GedMarc/bootstrap4-dialog contains all the required changes + all BS4 updates for colour themes (LESS Change) + extra wide width (size:extrawide)
Supports 4.0 alpha 3 -> Current 4.1

This repo doesn't look to be maintained, the other repo's have partial updates

nakupanda · 2018-06-27T08:25:22Z

I'm that one who is a bit out of date.. which one is best to be merged? or nothing to be merged?

firepol · 2018-07-01T07:51:42Z

@GedMarc I tested your repo in my project, it works, but I had to install it like this:

yarn add https://github.com/GedMarc/bootstrap4-dialog

and in my node_modules it still shows in the folder bootstrap3-dialog and in the packages.json it still shows as bootstrap3-dialog.

I'd expect it to show as bootstrap4-dialog. Maybe can you update the version and make it installable via npm, since this repo doesn't look updated much, it makes sense to make your fork more visible and discoverable...

Or @nakupanda do you plan any updates on this? Bootstrap 4 is stable since ages now...

GedMarc · 2018-07-01T08:30:53Z

@nakupanda Up to you bud! You did the bulk of the work xD I can do a pull request for you, but the request to update the bower packages to reflect the compatibility makes sense,
I think I'll be updating my package info tho -

GedMarc · 2018-07-01T10:00:15Z

@firepol I put it up, the version matches the current bootstrap 4 that it is compatible for :
https://www.npmjs.com/package/bootstrap4-dialog

npm install bootstrap4-dialog
bower install bootstrap4-dialog-gedmarc

From: avan06/bootstrap3-dialog Changed: - [b840b3e] Update bootstrapDialog for Bootstrap version 4.0. - [fc5a30b] FIXME for BootstrapV4.X

Update bootstrapDialog for Bootstrap version 4.0.

b840b3e

Merge remote-tracking branch

5fc9579

'choose_remote_name/revert-232-feature_mouseOverButton'

Merge branch 'master' of github.com:nakupanda/bootstrap3-dialog

7a6ce48

MadAlex2018 approved these changes Apr 20, 2018

View reviewed changes

leankuroneko approved these changes Apr 24, 2018

View reviewed changes

bindrid mentioned this pull request May 8, 2018

Issue with bootstrap-4.0 #376

Open

FIXME for BootstrapV4.X

fc5a30b

GedMarc suggested changes Jun 14, 2018

View reviewed changes

mcaskill added a commit to mcaskill/bootstrap-dialog that referenced this pull request Apr 1, 2019

Merge pull request nakupanda#281

0b645f6

From: avan06/bootstrap3-dialog Changed: - [b840b3e] Update bootstrapDialog for Bootstrap version 4.0. - [fc5a30b] FIXME for BootstrapV4.X

Kokil approved these changes Jun 23, 2020

View reviewed changes

Conversation

avan06 commented Jul 22, 2016

Uh oh!

ellisio commented Aug 4, 2016

Uh oh!

EugenMayer commented Aug 10, 2016

Uh oh!

EugenMayer commented Aug 10, 2016

Uh oh!

EugenMayer commented Aug 10, 2016

Uh oh!

EugenMayer commented Aug 10, 2016

Uh oh!

nakupanda commented Aug 11, 2016

Uh oh!

EugenMayer commented Aug 11, 2016

Uh oh!

digixweb commented Mar 8, 2017

Uh oh!

mediatvguy commented Apr 12, 2017

Uh oh!

EugenMayer commented Apr 12, 2017

Uh oh!

mediatvguy commented Apr 12, 2017

Uh oh!

nakupanda commented Apr 13, 2017

Uh oh!

bindrid commented Aug 19, 2017

Uh oh!

bindrid commented Aug 20, 2017

Uh oh!

Oviglo commented Aug 21, 2017

Uh oh!

nakupanda commented Aug 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alpertandogan commented Sep 4, 2017

Uh oh!

tmaly1980 commented Nov 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EugenMayer commented Nov 18, 2017

Uh oh!

tmaly1980 commented Dec 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

l0ft13 commented Jan 18, 2018

Uh oh!

Oviglo commented Mar 1, 2018

Uh oh!

Jako commented Mar 13, 2018

Uh oh!

leankuroneko commented Mar 13, 2018

Uh oh!

TCardinal commented Apr 5, 2018

Uh oh!

leankuroneko left a comment

Choose a reason for hiding this comment

Uh oh!

Oviglo commented Apr 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmihaig commented Jun 2, 2018

Uh oh!

GedMarc commented Jun 8, 2018

Uh oh!

alcidesfmelof commented Jun 13, 2018

Uh oh!

GedMarc commented Jun 13, 2018

Uh oh!

JavaTMP commented Jun 13, 2018

Uh oh!

GedMarc left a comment

Choose a reason for hiding this comment

Uh oh!

GedMarc commented Jun 18, 2018

Uh oh!

nakupanda commented Jun 27, 2018

Uh oh!

firepol commented Jul 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

nakupanda commented Aug 23, 2017 •

edited

Loading

tmaly1980 commented Nov 18, 2017 •

edited

Loading

tmaly1980 commented Dec 8, 2017 •

edited

Loading

Oviglo commented Apr 28, 2018 •

edited

Loading

firepol commented Jul 1, 2018 •

edited

Loading

GedMarc commented Jul 1, 2018 •

edited

Loading

GedMarc commented Jul 1, 2018 •

edited

Loading