fix(editor): Don't open form popup window if different trigger node is used #13391
+61
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autologie
commented
Feb 20, 2025
Comment on lines
-14
to
+10
| vi.mock('./executionUtils', async () => { | ||
| const actual = await vi.importActual('./executionUtils'); | ||
| return { | ||
| ...actual, | ||
| openFormPopupWindow: vi.fn(), | ||
| }; | ||
| }); | ||
| const windowOpenSpy = vi.spyOn(window, 'open'); |
There was a problem hiding this comment.
Replacing the spy target, because it seemed that displayForm function always calls the actual implementation of openFormPopupWindow
n8n-assistant
bot
added
n8n team
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
mutdmour
approved these changes
Feb 21, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
sug-16-unwanted-form-popup-on-manual-execution
|
| Run status |
|
| Run duration | 04m 31s |
| Commit |
|
| Committer | autologie |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
437
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the workflow has multiple trigger nodes, clicking on "Test workflow" button on other trigger nodes should not open the form popup window.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SUG-16/bug-form-popup-shows-when-executing-a-different-trigger-via-popup
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)