Skip to content

🎨 Palette: [UX improvement] Improve keyboard accessibility for scrollable regions and focus states #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n24q02m wants to merge 1 commit into from
Closed

🎨 Palette: [UX improvement] Improve keyboard accessibility for scrollable regions and focus states #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const description =

<h2>What is measured</h2>

<div class="scroller">
<div class="scroller" tabindex="0" role="region" aria-label="Measurement results">
<table>
<thead>
<tr><th>Setting</th><th>Result</th></tr>
Expand Down
19 changes: 17 additions & 2 deletions site/src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,14 @@ body {
text-decoration: none;
}

.nav a:hover,
.nav a:hover {
color: var(--accent);
}

.nav a:focus-visible {
color: var(--accent);
outline: 2px solid var(--accent);
outline-offset: 2px;
}

.theme-toggle {
Expand Down Expand Up @@ -198,9 +203,14 @@ li {
border: 1px solid var(--rule);
}

.btn:hover,
.btn:hover {
filter: brightness(1.08);
}

.btn:focus-visible {
filter: brightness(1.08);
outline: 2px solid var(--accent);
outline-offset: 2px;
}

.scroller {
Expand All @@ -211,6 +221,11 @@ li {
margin: 0 0 1.1rem;
}

.scroller:focus-visible {
outline: 2px solid var(--accent);
outline-offset: 2px;
}

table {
border-collapse: collapse;
width: 100%;
Expand Down
Loading