Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix swallowed exception tracebacks in custom FastAPI handler - #230

Open
n24q02m wants to merge 1 commit into
mainfrom
sentinel/fix-swallowed-traceback-logging-2366684217478521217
Open

πŸ›‘οΈ Sentinel: [MEDIUM] Fix swallowed exception tracebacks in custom FastAPI handler#230
n24q02m wants to merge 1 commit into
mainfrom
sentinel/fix-swallowed-traceback-logging-2366684217478521217

Conversation

@n24q02m

@n24q02m n24q02m commented Sep 7, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Swallowed server-side exception tracebacks. Overriding the default global Exception handler in FastAPI bypasses Starlette's default trace logging.
🎯 Impact: Server-side errors and potential exploitation attempts become invisible to operators because unhandled exceptions are silently swallowed, breaking the observability of 500 errors.
πŸ”§ Fix: Added explicit logging.error("Unhandled server exception", exc_info=_exc) in unhandled_exception_handler to securely log traces on the server while still returning a generic plain-text response to clients. Added journal learning to .jules/sentinel.md.
βœ… Verification: Tested via the existing test suite (uv run --all-extras pytest) and confirmed the generic 500 response behavior remains unchanged. Validated via ruff check and ruff format.


PR created automatically by Jules for task 2366684217478521217 started by @n24q02m

…stAPI handler

The custom global exception handler (`unhandled_exception_handler`) in `src/tacet/serve/server.py` suppressed Starlette's default `ServerErrorMiddleware` logging. This patch adds explicit `logging.error(..., exc_info=_exc)` to restore server-side visibility without leaking stack traces to the client.

Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant