π‘οΈ Sentinel: [security improvement] Fix swallowed exception tracebacks - #227
π‘οΈ Sentinel: [security improvement] Fix swallowed exception tracebacks#227n24q02m wants to merge 1 commit into
Conversation
β¦ception handler Explicitly log unhandled exceptions in the custom FastAPI Exception handler to prevent silent error swallowing due to bypassing Starlette's ServerErrorMiddleware. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: The custom global
Exceptionhandler bypassed Starlette'sServerErrorMiddleware, swallowing exceptions and blinding operators to critical server errors and tracebacks.π― Impact: Operational blindness; failures do not appear in application logs, making debugging and detecting exploits nearly impossible.
π§ Fix: Added explicit logging (
log.error("Unhandled server error", exc_info=_exc)) to the handler.β Verification: Verified via automated testing and log inspection.
PR created automatically by Jules for task 2513697026734509472 started by @n24q02m