🛡️ Sentinel: [MEDIUM] Fix swallowed exception stack traces - #224
Conversation
The `unhandled_exception_handler` was correctly obscuring stack traces from being sent to clients (returning a generic 500), but it neglected to log the exceptions server-side, resulting in completely swallowed tracebacks and blindspots for operators. Fixed by adding `log.error` with `exc_info`. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: The global exception handler was completely swallowing exceptions server-side, returning a generic 500 response without logging the actual exception traceback.
🎯 Impact: System operators and developers lose visibility into unhandled internal errors, making it impossible to debug or detect potential exploits/crashes occurring within the internal app logic.
🔧 Fix: Explicitly added
log.error("Unhandled exception", exc_info=_exc)to theunhandled_exception_handlerto ensure the traceback is logged securely server-side while maintaining the generic client response.✅ Verification: Ran
pytest tests/test_mvp.pyto ensure server endpoints continue to behave as expected.I also added an entry in the Sentinel journal documenting this pattern.
PR created automatically by Jules for task 4664680618045217379 started by @n24q02m