🛡️ Sentinel: [MEDIUM] Fix swallowed exception tracebacks in global error handler - #214
🛡️ Sentinel: [MEDIUM] Fix swallowed exception tracebacks in global error handler#214n24q02m wants to merge 1 commit into
Conversation
…ror handler
Overriding the FastAPI global exception handler in `src/tacet/serve/server.py` disabled Starlette's `ServerErrorMiddleware` logging behavior. By not explicitly logging the `_exc` internally within the handler before sending the 500 response, any generic internal server error traceback was swallowed rather than written to the application's stderr log. This severely impacted the observability of the service and our ability to monitor unexpected faults.
Added explicit `logging.error("Unhandled server exception", exc_info=_exc)` to the `unhandled_exception_handler` to properly log the trace server-side without leaking it to the client.
Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: The global catch-all Exception handler (
@app.exception_handler(Exception)) correctly masked internal server errors behind a genericPlainTextResponse("Internal Server Error", status_code=500)and correctly applied security headers to those failure responses. However, because it overrides Starlette'sServerErrorMiddlewareand caught the exception without explicitly logging it, the traceback was entirely swallowed. The error was never logged on the server.🎯 Impact: Zero observability into generic unhandled application crashes or unexpected failure states. This prevents debugging real vulnerabilities or critical application bugs in production, effectively blinding the server operators to internal faults.
🔧 Fix: Add
logging.error("Unhandled server exception", exc_info=_exc)directly in theunhandled_exception_handlerto explicitly log the exception stack trace to stderr before returning the safe 500 response to the client.✅ Verification:
uv run --all-extras pytestsuccessfully completes.uv run ruff check .anduv run ruff format .pass without issues. Reviewedsrc/tacet/serve/server.pymanually.PR created automatically by Jules for task 9882830938349219736 started by @n24q02m