* fix converting the value of query param orderBy.direction from `s…

…tring` to `bool` that forcing any direction get treated as `DESC` @ `App\PostsQuery\SearchQuery->query()` * fix the fallback value of `$cursor` should be stringify integer to pass the following validating with `ctype_digit()` @ `App\Controller\SitemapController->forums()` @ be
n0099 · Oct 14, 2024 · fa89c03 · fa89c03
1 parent 122379f
commit fa89c03
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/be/src/Controller/SitemapController.php b/be/src/Controller/SitemapController.php
@@ -48,7 +48,7 @@ function (ItemInterface $item) use ($threadsIdKeyByFid) {
     #[Route('/sitemaps/forums/{fid}/threads', requirements: ['fid' => /** @lang JSRegexp */'\d+'])]
     public function threads(Request $request, Validator $validator, int $fid): Response
     {
-        $cursor = $request->query->get('cursor') ?? 0;
+        $cursor = $request->query->get('cursor') ?? '0';
         $validator->validate($cursor, new Assert\Type('digit'));
         Helper::abortAPIIfNot(40406, $this->forumRepository->isForumExists($fid));
 

diff --git a/be/src/PostsQuery/SearchQuery.php b/be/src/PostsQuery/SearchQuery.php
@@ -29,7 +29,7 @@ public function query(QueryParams $params, ?string $cursor): void
 
         $orderByParam = $params->pick('orderBy')[0];
         $this->setOrderByField($orderByParam->value === 'default' ? 'postedAt' : $orderByParam->value);
-        $this->setOrderByDesc($orderByParam->value === 'default' ? true : $orderByParam->getSub('direction'));
+        $this->setOrderByDesc($orderByParam->value === 'default' || $orderByParam->getSub('direction') === 'DESC');
 
         /** @var array<string, array> $cachedUserQueryResult key by param name */
         $cachedUserQueryResult = [];