Improve wording for the Builder::discovery fn #3582
Conversation
Signed-off-by: Matthias Beyer <[email protected]>
| /// The internals of the [`Builder`] use the discovery objects passed to this function and | ||
| /// automatically combines them upon [`Builder::bind`] via a |
There was a problem hiding this comment.
If you call this method multiple times, all discovery services passed in will be combined via an internal [
crate::discovery::ConcurrentDiscovery]. To remove all discovery services already added to the builder use [Self::clear_discovery].
Would be my attempt. And that would remove the separate paragraph about clearing below.
Would be great if you could also fix the wrong function name in the paragraph above and link it to [IntoDiscovery::into_discovery]
|
Stop merging to other peoples PRs! |
If this is directed at me, it's my job to ensure that our releases go out in a timely fashion and to help folks get their PRs merged ASAP for that. I apologize for the frustration but: |
This is a setting you have control over in GitHub: But I'd kindly ask you to reserve us the right to modify your PRs, as that makes our lives easier. |
4 participants
Description
After discussion on discord with @flub I tried to improve the wording of the function a bit here.
I am open to discussion of course.